From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0bjACo2qyGBvZwAAWB0awg (envelope-from ) for ; Tue, 15 Jun 2021 09:26:37 -0400 Received: by simark.ca (Postfix, from userid 112) id 1A63D1F163; Tue, 15 Jun 2021 09:26:37 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A462F1E939 for ; Tue, 15 Jun 2021 09:26:35 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E8BC83945C07 for ; Tue, 15 Jun 2021 13:26:34 +0000 (GMT) Received: from gateway33.websitewelcome.com (gateway33.websitewelcome.com [192.185.146.195]) by sourceware.org (Postfix) with ESMTPS id 830CA3858012 for ; Tue, 15 Jun 2021 13:26:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 830CA3858012 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tromey.com Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway33.websitewelcome.com (Postfix) with ESMTP id E3E869207 for ; Tue, 15 Jun 2021 08:26:21 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id t95BlkfOYMGeEt95BlVG27; Tue, 15 Jun 2021 08:26:21 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=j2rYg9VcgtI8lDS/V3yO3nt1cjEuFhDrP45E/qrpP+Q=; b=C8Wmu3BxaryPypsT2Ja+UODnjk cGsEM0qVVbyN1/t7j/eM8R5jCMJ2o694WqopO934eljw+gTeYuFlGAdr+8vuXje/btUfWl2OvpnLc 6xQjvdrVDkPQ29fUIwcw51W+m; Received: from 97-122-95-220.hlrn.qwest.net ([97.122.95.220]:40374 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lt95B-0010Uc-Di; Tue, 15 Jun 2021 07:26:21 -0600 From: Tom Tromey To: Tom de Vries Subject: Re: [RFC][gdb/symtab] Lazy expansion of full symbol table References: <20210614093908.GA22709@delia> <87pmwoxj3j.fsf@tromey.com> <533bf7e4-d96c-a6b7-8c37-a4141ebdc761@suse.de> X-Attribution: Tom Date: Tue, 15 Jun 2021 07:26:20 -0600 In-Reply-To: <533bf7e4-d96c-a6b7-8c37-a4141ebdc761@suse.de> (Tom de Vries's message of "Tue, 15 Jun 2021 01:36:49 +0200") Message-ID: <87im2fxnr7.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.95.220 X-Source-L: No X-Exim-ID: 1lt95B-0010Uc-Di X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-95-220.hlrn.qwest.net (localhost.localdomain) [97.122.95.220]:40374 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Tromey , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" >> I don't have this executable Tom> Uploaded to https://ftp.suse.com/pub/people/tdevries/gdb/pr23710/cc1 Thanks, I grabbed it. >> but FWIW my scanner rewrite is ~10x faster >> than the current psymtab reader. Tom> Interesting, that's Tom> https://github.com/tromey/gdb/commits/submit/no-more-psym ? Tom> I've tried that branch with the cc1 example, and ran into: Tom> ... Tom> DW_FORM_strp pointing outside of .debug_str section [in module cc1] Thank you for trying it. This was a bug in the CU importing code. I've fixed it and will push momentarily -- but be warned, I rebase this branch a lot... On my machine, with "maint time 1", /bin/gdb reports: (gdb) file ./cc1 2021-06-15 07:18:29.554 - command started Reading symbols from ./cc1... 2021-06-15 07:18:35.118 - command finished Command execution time: 5.553344 (cpu), 5.563964 (wall) The branch says: (gdb) file ./cc1 2021-06-15 07:18:50.688 - command started Reading symbols from ./cc1... 2021-06-15 07:18:51.074 - command finished Command execution time: 1.260050 (cpu), 0.386460 (wall) So a bit more than 10x in this case. I wish it were a tiny bit faster, so that it wasn't perceptible, but meh, DWARF wasn't designed to be fast to read. Currently I think the scanner is complete, I just need to make some changes to the lookup code, and maybe also how the new index entries are stored, so that completion is more efficient. Of course there may still be bugs, but at the moment I don't anticipate any reader slowdowns. Tom