Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [PATCH] ep_is_catchpoint -> is_catchpoint
@ 2012-04-23  6:49 Yao Qi
  2012-04-23 13:42 ` Tom Tromey
  2012-04-24 13:55 ` Yao Qi
  0 siblings, 2 replies; 4+ messages in thread
From: Yao Qi @ 2012-04-23  6:49 UTC (permalink / raw)
  To: gdb-patches

This patch is to rename ep_is_catchpoint to is_catchpoint, like its
friends, is_watchpoint and is_tracepoint.

It is obvious, and I'll commit it tomorrow.

gdb:

2012-04-23  Yao Qi  <yao@codesourcery.com>

	* breakpoint.c (ep_is_catchpoint): Renamed to ...
	(is_catchpoint): ... it.
	(print_one_breakpoint_location): Caller update.
	* breakpoint.h: Update declaration.
---
 gdb/breakpoint.c |    4 ++--
 gdb/breakpoint.h |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index be536bc..ceca221 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -3635,7 +3635,7 @@ breakpoint_thread_match (struct address_space *aspace, CORE_ADDR pc,
    in breakpoint.h.  */
 
 int
-ep_is_catchpoint (struct breakpoint *ep)
+is_catchpoint (struct breakpoint *ep)
 {
   return (ep->type == bp_catchpoint);
 }
@@ -5600,7 +5600,7 @@ print_one_breakpoint_location (struct breakpoint *b,
   if (!part_of_multiple && b->hit_count)
     {
       /* FIXME should make an annotation for this.  */
-      if (ep_is_catchpoint (b))
+      if (is_catchpoint (b))
 	ui_out_text (uiout, "\tcatchpoint");
       else if (is_tracepoint (b))
 	ui_out_text (uiout, "\ttracepoint");
diff --git a/gdb/breakpoint.h b/gdb/breakpoint.h
index e0eeeaa..e676659 100644
--- a/gdb/breakpoint.h
+++ b/gdb/breakpoint.h
@@ -1365,7 +1365,7 @@ extern void remove_thread_event_breakpoints (void);
 extern void disable_breakpoints_in_shlibs (void);
 
 /* This function returns TRUE if ep is a catchpoint.  */
-extern int ep_is_catchpoint (struct breakpoint *);
+extern int is_catchpoint (struct breakpoint *);
 
 /* Enable breakpoints and delete when hit.  Called with ARG == NULL
    deletes all breakpoints.  */
-- 
1.7.0.4


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ep_is_catchpoint -> is_catchpoint
  2012-04-23  6:49 [PATCH] ep_is_catchpoint -> is_catchpoint Yao Qi
@ 2012-04-23 13:42 ` Tom Tromey
  2012-04-23 13:55   ` Yao Qi
  2012-04-24 13:55 ` Yao Qi
  1 sibling, 1 reply; 4+ messages in thread
From: Tom Tromey @ 2012-04-23 13:42 UTC (permalink / raw)
  To: Yao Qi; +Cc: gdb-patches

>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

Yao> This patch is to rename ep_is_catchpoint to is_catchpoint, like its
Yao> friends, is_watchpoint and is_tracepoint.

I always wondered what those "ep_" prefixes meant.

Tom


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ep_is_catchpoint -> is_catchpoint
  2012-04-23 13:42 ` Tom Tromey
@ 2012-04-23 13:55   ` Yao Qi
  0 siblings, 0 replies; 4+ messages in thread
From: Yao Qi @ 2012-04-23 13:55 UTC (permalink / raw)
  To: Tom Tromey; +Cc: gdb-patches

On 04/23/2012 09:34 PM, Tom Tromey wrote:
>>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
> 
> Yao> This patch is to rename ep_is_catchpoint to is_catchpoint, like its
> Yao> friends, is_watchpoint and is_tracepoint.
> 
> I always wondered what those "ep_" prefixes meant.
> 

These "ep_" prefixes existed when source was imported in CVS repository.
I guess "ep" means "eventpoint", as found in the comments of ancient GDB
source (in year 2000).

-- 
Yao (齐尧)


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ep_is_catchpoint -> is_catchpoint
  2012-04-23  6:49 [PATCH] ep_is_catchpoint -> is_catchpoint Yao Qi
  2012-04-23 13:42 ` Tom Tromey
@ 2012-04-24 13:55 ` Yao Qi
  1 sibling, 0 replies; 4+ messages in thread
From: Yao Qi @ 2012-04-24 13:55 UTC (permalink / raw)
  To: gdb-patches

On 04/23/2012 02:36 PM, Yao Qi wrote:
> It is obvious, and I'll commit it tomorrow.
> 
> gdb:
> 
> 2012-04-23  Yao Qi  <yao@codesourcery.com>
> 
> 	* breakpoint.c (ep_is_catchpoint): Renamed to ...
> 	(is_catchpoint): ... it.
> 	(print_one_breakpoint_location): Caller update.
> 	* breakpoint.h: Update declaration.

Committed.

-- 
Yao (齐尧)


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-04-24 13:22 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-23  6:49 [PATCH] ep_is_catchpoint -> is_catchpoint Yao Qi
2012-04-23 13:42 ` Tom Tromey
2012-04-23 13:55   ` Yao Qi
2012-04-24 13:55 ` Yao Qi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox