From: Tom Tromey <tromey@redhat.com>
To: Andreas Kaufmann <Andreas.Kaufmann@synopsys.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix for 15072: stopped response missing for reverse-finish
Date: Thu, 25 Apr 2013 08:19:00 -0000 [thread overview]
Message-ID: <87haivlkna.fsf@fleche.redhat.com> (raw)
In-Reply-To: <5570CCEF7886EE48BAAD632645A58FDA12829B3A@DE02WEMBXB.internal.synopsys.com> (Andreas Kaufmann's message of "Mon, 22 Apr 2013 07:33:51 +0000")
>>>>> "Andreas" == Andreas Kaufmann <Andreas.Kaufmann@synopsys.com> writes:
Andreas> The above is not done (and nor needed) for "reverse-finish". So
Andreas> I added additional check "execution_direction != EXEC_REVERSE"
Andreas> to ensure that observer_notify_normal_stop() is called for
Andreas> "reverse-finish" from normal_stop() in gdb/infrun.c.
It seems reasonable to me (though this isn't really my area and so Pedro
should probably weigh in).
Andreas> 2013-04-18 Andreas Kaufmann <Andreas.Kaufmann@synopsys.com>
Andreas> PR gdb/15072
Andreas> * infrun.c (normal_stop): Ensure "observer_notify_normal_stop" is called
Andreas> when "reverse-finish" command hits a breakpoint.
I think a test case is needed.
But that will probably push the patch over the limit where we need
copyright papers (unless maybe there is some way to see the bug with the
CLI and the test case can be added to an existing file). Contact me
off-list to get started on that; or if you already have them in place
and I forgot, just mention it. Thanks.
Tom
next prev parent reply other threads:[~2013-04-24 20:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-22 14:01 Andreas Kaufmann
2013-04-22 14:54 ` Abid, Hafiz
2013-04-25 8:19 ` Tom Tromey [this message]
2013-05-15 15:49 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87haivlkna.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=Andreas.Kaufmann@synopsys.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox