From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9004 invoked by alias); 24 Apr 2013 20:49:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8978 invoked by uid 89); 24 Apr 2013 20:49:01 -0000 X-Spam-SWARE-Status: No, score=-7.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 24 Apr 2013 20:49:01 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3OKmxlU029099 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 24 Apr 2013 16:48:59 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r3OKmvpT005318 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 24 Apr 2013 16:48:58 -0400 From: Tom Tromey To: Andreas Kaufmann Cc: "gdb-patches\@sourceware.org" Subject: Re: [PATCH] Fix for 15072: stopped response missing for reverse-finish References: <5570CCEF7886EE48BAAD632645A58FDA12829B3A@DE02WEMBXB.internal.synopsys.com> Date: Thu, 25 Apr 2013 08:19:00 -0000 In-Reply-To: <5570CCEF7886EE48BAAD632645A58FDA12829B3A@DE02WEMBXB.internal.synopsys.com> (Andreas Kaufmann's message of "Mon, 22 Apr 2013 07:33:51 +0000") Message-ID: <87haivlkna.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-04/txt/msg00763.txt.bz2 >>>>> "Andreas" == Andreas Kaufmann writes: Andreas> The above is not done (and nor needed) for "reverse-finish". So Andreas> I added additional check "execution_direction != EXEC_REVERSE" Andreas> to ensure that observer_notify_normal_stop() is called for Andreas> "reverse-finish" from normal_stop() in gdb/infrun.c. It seems reasonable to me (though this isn't really my area and so Pedro should probably weigh in). Andreas> 2013-04-18 Andreas Kaufmann Andreas> PR gdb/15072 Andreas> * infrun.c (normal_stop): Ensure "observer_notify_normal_stop" is called Andreas> when "reverse-finish" command hits a breakpoint. I think a test case is needed. But that will probably push the patch over the limit where we need copyright papers (unless maybe there is some way to see the bug with the CLI and the test case can be added to an existing file). Contact me off-list to get started on that; or if you already have them in place and I forgot, just mention it. Thanks. Tom