Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andreas Arnez <arnez@linux.vnet.ibm.com>
To: gdb-patches@sourceware.org
Cc: Kevin Buettner <kevinb@redhat.com>
Subject: [RFC 07/23] MN10300: Replace regset_alloc() invocations by static regset structures
Date: Mon, 28 Apr 2014 09:49:00 -0000	[thread overview]
Message-ID: <87ha5d4wdu.fsf@br87z6lw.de.ibm.com> (raw)
In-Reply-To: <87eh0h6bkq.fsf@br87z6lw.de.ibm.com> (Andreas Arnez's message of	"Mon, 28 Apr 2014 11:35:33 +0200")

On this architecture the change may fix a small memory leak.

gdb/
	* mn10300-linux-tdep.c (am33_gregset, am33_fpregset): New static
	regset structures.
	(am33_regset_from_core_section): Remove dynamic regset
	allocations.
---
 gdb/mn10300-linux-tdep.c | 21 ++++++++++++---------
 1 file changed, 12 insertions(+), 9 deletions(-)

diff --git a/gdb/mn10300-linux-tdep.c b/gdb/mn10300-linux-tdep.c
index 6acae56..4377463 100644
--- a/gdb/mn10300-linux-tdep.c
+++ b/gdb/mn10300-linux-tdep.c
@@ -451,6 +451,16 @@ am33_collect_fpregset_method (const struct regset *regset,
   return;
 }
 
+static const struct regset am33_gregset =
+  {
+    NULL, am33_supply_gregset_method, am33_collect_gregset_method
+  };
+
+static const struct regset am33_fpregset =
+  {
+    NULL, am33_supply_fpregset_method, am33_collect_fpregset_method
+  };
+
 /* Create a struct regset from a corefile register section.  */
 
 static const struct regset *
@@ -458,17 +468,10 @@ am33_regset_from_core_section (struct gdbarch *gdbarch,
 			       const char *sect_name, 
 			       size_t sect_size)
 {
-  /* We will call regset_alloc, and pass the names of the supply and
-     collect methods.  */
-
   if (sect_size == sizeof (mn10300_elf_fpregset_t))
-    return regset_alloc (gdbarch, 
-			 am33_supply_fpregset_method,
-			 am33_collect_fpregset_method);
+    return &am33_fpregset;
   else
-    return regset_alloc (gdbarch, 
-			 am33_supply_gregset_method,
-			 am33_collect_gregset_method);
+    return &am33_gregset;
 }
 \f
 static void
-- 
1.8.4.2


  parent reply	other threads:[~2014-04-28  9:49 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-28  9:35 [RFC 00/23] Regset rework preparations Andreas Arnez
2014-04-28  9:39 ` [RFC 01/23] Constify regset structures Andreas Arnez
2014-05-05  9:45   ` Mark Kettenis
2014-04-28  9:40 ` [RFC 02/23] Remove 'arch' field from regset structure Andreas Arnez
2014-05-05  9:32   ` Mark Kettenis
2014-05-05 13:35     ` Andreas Arnez
2014-04-28  9:44 ` [RFC 03/23] AARCH64: Replace regset_alloc() invocations by static regset structures Andreas Arnez
2014-04-28  9:46 ` [RFC 04/23] ARM: " Andreas Arnez
2014-04-28  9:47 ` [RFC 05/23] X86: " Andreas Arnez
2014-04-28 15:33   ` Mark Kettenis
2014-04-29  8:58     ` Andreas Arnez
2014-04-28  9:48 ` [RFC 06/23] MIPS: " Andreas Arnez
2014-04-28  9:49 ` Andreas Arnez [this message]
2014-04-28  9:50 ` [RFC 08/23] SCORE: Replace regset_alloc() invocation by a static regset structure Andreas Arnez
2014-04-28  9:51 ` [RFC 09/23] SPARC: Rename register maps from "*regset" to "*regmap" Andreas Arnez
2014-05-05  9:50   ` Mark Kettenis
2014-04-28  9:52 ` [RFC 10/23] SPARC: Replace regset_alloc() invocations by static regset structures Andreas Arnez
2014-05-05  9:52   ` Mark Kettenis
2014-04-28  9:53 ` [RFC 11/23] Drop regset_alloc() Andreas Arnez
2014-05-05  9:53   ` Mark Kettenis
2014-04-28  9:54 ` [RFC 13/23] S390: Migrate to regcache_supply/collect_regset Andreas Arnez
2014-04-28  9:54 ` [RFC 12/23] regcache: Add functions suitable for regset_supply/collect Andreas Arnez
2014-05-05 10:02   ` Mark Kettenis
2014-05-05 15:34     ` Andreas Arnez
2014-04-28  9:55 ` [RFC 14/23] AARCH64 Linux: Fill 'collect_regset' in regset structures Andreas Arnez
2014-04-28  9:56 ` [RFC 15/23] ALPHA " Andreas Arnez
2014-04-28  9:57 ` [RFC 16/23] FRV " Andreas Arnez
2014-04-28  9:58 ` [RFC 17/23] HPPA " Andreas Arnez
2014-04-28  9:59 ` [RFC 19/23] NIOS2 Linux: Fill 'collect_regset' in regset structure Andreas Arnez
2014-04-28  9:59 ` [RFC 18/23] M32R " Andreas Arnez
2014-04-28 10:00 ` [RFC 20/23] SCORE: " Andreas Arnez
2014-04-28 10:01 ` [RFC 22/23] M68K Linux: Define regset structures Andreas Arnez
2014-04-28 10:01 ` [RFC 21/23] TILEGX Linux: Fill 'collect_regset' in regset structure Andreas Arnez
2014-04-28 10:02 ` [RFC 23/23] IA64 Linux: Define regset structures Andreas Arnez
2014-04-28 15:29 ` [RFC 00/23] Regset rework preparations Maciej W. Rozycki
2014-04-28 15:38   ` Andreas Arnez
2014-05-08 10:31     ` Andreas Arnez
2014-05-05  8:09 ` [ping] " Andreas Arnez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ha5d4wdu.fsf@br87z6lw.de.ibm.com \
    --to=arnez@linux.vnet.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=kevinb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox