From: Andreas Arnez <arnez@linux.vnet.ibm.com>
To: gdb-patches@sourceware.org
Cc: Qinwei <qinwei@sunnorth.com.cn>
Subject: [RFC 08/23] SCORE: Replace regset_alloc() invocation by a static regset structure
Date: Mon, 28 Apr 2014 09:50:00 -0000 [thread overview]
Message-ID: <87d2g14wcg.fsf@br87z6lw.de.ibm.com> (raw)
In-Reply-To: <87eh0h6bkq.fsf@br87z6lw.de.ibm.com> (Andreas Arnez's message of "Mon, 28 Apr 2014 11:35:33 +0200")
Since this changes makes the only member of the tdep structure
obsolete, the tdep structure is removed.
gdb/
* score-tdep.c (score7_linux_gregset): New static regset
structure.
(score7_linux_regset_from_core_section): Remove dynamic regset
allocation.
(score_gdbarch_init): Drop allocation of tdep structure.
* score-tdep.h (struct gdbarch_tdep): Remove declaration.
---
gdb/score-tdep.c | 21 ++++++++-------------
gdb/score-tdep.h | 7 -------
2 files changed, 8 insertions(+), 20 deletions(-)
diff --git a/gdb/score-tdep.c b/gdb/score-tdep.c
index 078315a..c224189 100644
--- a/gdb/score-tdep.c
+++ b/gdb/score-tdep.c
@@ -1447,6 +1447,12 @@ score7_linux_supply_gregset(const struct regset *regset,
}
}
+static const struct regset score7_linux_gregset =
+ {
+ NULL,
+ score7_linux_supply_gregset, NULL
+ };
+
/* Return the appropriate register set from the core section identified
by SECT_NAME and SECT_SIZE. */
@@ -1454,20 +1460,11 @@ static const struct regset *
score7_linux_regset_from_core_section(struct gdbarch *gdbarch,
const char *sect_name, size_t sect_size)
{
- struct gdbarch_tdep *tdep;
-
gdb_assert (gdbarch != NULL);
gdb_assert (sect_name != NULL);
- tdep = gdbarch_tdep (gdbarch);
-
if (strcmp(sect_name, ".reg") == 0 && sect_size == sizeof(elf_gregset_t))
- {
- if (tdep->gregset == NULL)
- tdep->gregset = regset_alloc (gdbarch,
- score7_linux_supply_gregset, NULL);
- return tdep->gregset;
- }
+ return &score7_linux_gregset;
return NULL;
}
@@ -1476,7 +1473,6 @@ static struct gdbarch *
score_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
{
struct gdbarch *gdbarch;
- struct gdbarch_tdep *tdep;
target_mach = info.bfd_arch_info->mach;
arches = gdbarch_list_lookup_by_info (arches, &info);
@@ -1484,8 +1480,7 @@ score_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
{
return (arches->gdbarch);
}
- tdep = xcalloc(1, sizeof(struct gdbarch_tdep));
- gdbarch = gdbarch_alloc (&info, tdep);
+ gdbarch = gdbarch_alloc (&info, NULL);
set_gdbarch_short_bit (gdbarch, 16);
set_gdbarch_int_bit (gdbarch, 32);
diff --git a/gdb/score-tdep.h b/gdb/score-tdep.h
index b34f5a9..02a334e 100644
--- a/gdb/score-tdep.h
+++ b/gdb/score-tdep.h
@@ -49,13 +49,6 @@ enum gdb_regnum
/* Forward declarations. */
struct regset;
-/* Target-dependent structure in gdbarch */
-struct gdbarch_tdep
-{
- /* Cached core file helpers. */
- struct regset *gregset;
-};
-
/* Linux Core file support (dirty hack)
S+core Linux register set definition, copy from S+core Linux. */
--
1.8.4.2
next prev parent reply other threads:[~2014-04-28 9:50 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 9:35 [RFC 00/23] Regset rework preparations Andreas Arnez
2014-04-28 9:39 ` [RFC 01/23] Constify regset structures Andreas Arnez
2014-05-05 9:45 ` Mark Kettenis
2014-04-28 9:40 ` [RFC 02/23] Remove 'arch' field from regset structure Andreas Arnez
2014-05-05 9:32 ` Mark Kettenis
2014-05-05 13:35 ` Andreas Arnez
2014-04-28 9:44 ` [RFC 03/23] AARCH64: Replace regset_alloc() invocations by static regset structures Andreas Arnez
2014-04-28 9:46 ` [RFC 04/23] ARM: " Andreas Arnez
2014-04-28 9:47 ` [RFC 05/23] X86: " Andreas Arnez
2014-04-28 15:33 ` Mark Kettenis
2014-04-29 8:58 ` Andreas Arnez
2014-04-28 9:48 ` [RFC 06/23] MIPS: " Andreas Arnez
2014-04-28 9:49 ` [RFC 07/23] MN10300: " Andreas Arnez
2014-04-28 9:50 ` Andreas Arnez [this message]
2014-04-28 9:51 ` [RFC 09/23] SPARC: Rename register maps from "*regset" to "*regmap" Andreas Arnez
2014-05-05 9:50 ` Mark Kettenis
2014-04-28 9:52 ` [RFC 10/23] SPARC: Replace regset_alloc() invocations by static regset structures Andreas Arnez
2014-05-05 9:52 ` Mark Kettenis
2014-04-28 9:53 ` [RFC 11/23] Drop regset_alloc() Andreas Arnez
2014-05-05 9:53 ` Mark Kettenis
2014-04-28 9:54 ` [RFC 12/23] regcache: Add functions suitable for regset_supply/collect Andreas Arnez
2014-05-05 10:02 ` Mark Kettenis
2014-05-05 15:34 ` Andreas Arnez
2014-04-28 9:54 ` [RFC 13/23] S390: Migrate to regcache_supply/collect_regset Andreas Arnez
2014-04-28 9:55 ` [RFC 14/23] AARCH64 Linux: Fill 'collect_regset' in regset structures Andreas Arnez
2014-04-28 9:56 ` [RFC 15/23] ALPHA " Andreas Arnez
2014-04-28 9:57 ` [RFC 16/23] FRV " Andreas Arnez
2014-04-28 9:58 ` [RFC 17/23] HPPA " Andreas Arnez
2014-04-28 9:59 ` [RFC 18/23] M32R Linux: Fill 'collect_regset' in regset structure Andreas Arnez
2014-04-28 9:59 ` [RFC 19/23] NIOS2 " Andreas Arnez
2014-04-28 10:00 ` [RFC 20/23] SCORE: " Andreas Arnez
2014-04-28 10:01 ` [RFC 22/23] M68K Linux: Define regset structures Andreas Arnez
2014-04-28 10:01 ` [RFC 21/23] TILEGX Linux: Fill 'collect_regset' in regset structure Andreas Arnez
2014-04-28 10:02 ` [RFC 23/23] IA64 Linux: Define regset structures Andreas Arnez
2014-04-28 15:29 ` [RFC 00/23] Regset rework preparations Maciej W. Rozycki
2014-04-28 15:38 ` Andreas Arnez
2014-05-08 10:31 ` Andreas Arnez
2014-05-05 8:09 ` [ping] " Andreas Arnez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d2g14wcg.fsf@br87z6lw.de.ibm.com \
--to=arnez@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=qinwei@sunnorth.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox