From: Tom Tromey <tom@tromey.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA 1/5] Remove regcache_xmalloc
Date: Tue, 26 Sep 2017 04:55:00 -0000 [thread overview]
Message-ID: <87h8vqkqrm.fsf@tromey.com> (raw)
In-Reply-To: <20170924024608.4346-2-tom@tromey.com> (Tom Tromey's message of "Sat, 23 Sep 2017 20:46:04 -0600")
>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
Tom> + struct regcache *regcache = new regcache (data.gdbarch, aspace);
The builder complained about this line.
It had to be 'new struct regcache' instead.
However, this was change in a subsequent commit, so my try run didn't
catch it. I suppose I will have to start doing try runs for each
individual patch; which is kind of a pain :(
Anyway, I'm sorry about this. The only good thing is that you probably
won't hit this problem unless you bisect.
Tom
next prev parent reply other threads:[~2017-09-26 4:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-24 2:46 [RFA 0/5] remove cleanups from regcache Tom Tromey
2017-09-24 2:46 ` [RFA 3/5] Remove make_cleanup_regcache_xfree Tom Tromey
2017-09-24 2:46 ` [RFA 2/5] Remove regcache_xfree Tom Tromey
2017-09-24 2:46 ` [RFA 5/5] Remove the last cleanup from regcache.c Tom Tromey
2017-09-24 2:46 ` [RFA 4/5] Remove make_cleanup_regcache_invalidate Tom Tromey
2017-09-25 20:04 ` Yao Qi
2017-09-26 1:36 ` Tom Tromey
2017-09-26 1:56 ` Tom Tromey
2017-09-24 2:46 ` [RFA 1/5] Remove regcache_xmalloc Tom Tromey
2017-09-26 4:55 ` Tom Tromey [this message]
2017-09-26 5:10 ` Sergio Durigan Junior
2017-09-26 0:08 ` [RFA 0/5] remove cleanups from regcache Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h8vqkqrm.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox