From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 95977 invoked by alias); 26 Sep 2017 04:55:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 95967 invoked by uid 89); 26 Sep 2017 04:55:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: gproxy7-pub.mail.unifiedlayer.com Received: from gproxy7-pub.mail.unifiedlayer.com (HELO gproxy7-pub.mail.unifiedlayer.com) (70.40.196.235) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 26 Sep 2017 04:55:03 +0000 Received: from cmgw3 (unknown [10.0.90.84]) by gproxy7.mail.unifiedlayer.com (Postfix) with ESMTP id C952B218287 for ; Mon, 25 Sep 2017 22:50:09 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id E4q61w00e2f2jeq014q9Fe; Mon, 25 Sep 2017 22:50:09 -0600 X-Authority-Analysis: v=2.2 cv=K/VSJ2eI c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=2JCJgTwv5E4A:10 a=zstS-IiYAAAA:8 a=C5Myw8lrhHL7llZ4Um0A:9 a=4G6NA9xxw8l3yy4pmD5M:22 Received: from 75-166-76-94.hlrn.qwest.net ([75.166.76.94]:48624 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1dwhos-000OAk-O3; Mon, 25 Sep 2017 22:50:06 -0600 From: Tom Tromey To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA 1/5] Remove regcache_xmalloc References: <20170924024608.4346-1-tom@tromey.com> <20170924024608.4346-2-tom@tromey.com> Date: Tue, 26 Sep 2017 04:55:00 -0000 In-Reply-To: <20170924024608.4346-2-tom@tromey.com> (Tom Tromey's message of "Sat, 23 Sep 2017 20:46:04 -0600") Message-ID: <87h8vqkqrm.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1dwhos-000OAk-O3 X-Source-Sender: 75-166-76-94.hlrn.qwest.net (bapiya) [75.166.76.94]:48624 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Local-Domain: yes X-SW-Source: 2017-09/txt/msg00783.txt.bz2 >>>>> "Tom" == Tom Tromey writes: Tom> + struct regcache *regcache = new regcache (data.gdbarch, aspace); The builder complained about this line. It had to be 'new struct regcache' instead. However, this was change in a subsequent commit, so my try run didn't catch it. I suppose I will have to start doing try runs for each individual patch; which is kind of a pain :( Anyway, I'm sorry about this. The only good thing is that you probably won't hit this problem unless you bisect. Tom