From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] Make "all" depend on "info"
Date: Sat, 20 Oct 2018 22:13:00 -0000 [thread overview]
Message-ID: <87h8hguv04.fsf@redhat.com> (raw)
In-Reply-To: <20181020183429.21188-1-tom@tromey.com> (Tom Tromey's message of "Sat, 20 Oct 2018 12:34:29 -0600")
On Saturday, October 20 2018, Tom Tromey wrote:
> I've broken "make info" a couple of times now, because I sometimes
> forget to run "make info" after modifying a Texinfo file.
>
> I don't know why gdb's "make all" doesn't build the info pages. I
> suspect this was some Cygnus-local oddity back in the day.
>
> This patch changes doc/Makefile.in so that the info pages are built by
> "make all". As a point of reference, Automake has essentially always
> worked this way. According to the Automake manual (I didn't
> double-check) this is required by the GNU coding standards.
I think it makes sense, especially because "info" the default
documentation format for GNU.
I was wondering if it would also make sense to build the documentation
on the BuildBot.
> gdb/doc/ChangeLog
> 2018-10-20 Tom Tromey <tom@tromey.com>
>
> * Makefile.in (all): Depend on "info".
> ---
> gdb/doc/ChangeLog | 4 ++++
> gdb/doc/Makefile.in | 2 +-
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/doc/Makefile.in b/gdb/doc/Makefile.in
> index 0323bc4ecb..4e167d59cf 100644
> --- a/gdb/doc/Makefile.in
> +++ b/gdb/doc/Makefile.in
> @@ -182,7 +182,7 @@ HAVE_NATIVE_GCORE_TARGET = @HAVE_NATIVE_GCORE_TARGET@
>
> ###
>
> -all:
> +all: info
>
> info: $(INFO_DEPS)
> dvi: gdb.dvi stabs.dvi refcard.dvi annotate.dvi
> --
> 2.17.1
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
next prev parent reply other threads:[~2018-10-20 22:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-20 18:34 Tom Tromey
2018-10-20 21:20 ` Simon Marchi
2018-10-20 21:44 ` Kevin Buettner
2018-10-20 22:13 ` Sergio Durigan Junior [this message]
2018-11-29 19:23 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h8hguv04.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox