From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 39525 invoked by alias); 20 Oct 2018 22:13:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 39508 invoked by uid 89); 20 Oct 2018 22:13:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=237A, 7628, 0287, 31F4 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 20 Oct 2018 22:13:32 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 852F630832C2; Sat, 20 Oct 2018 22:13:31 +0000 (UTC) Received: from localhost (unused-10-15-17-196.yyz.redhat.com [10.15.17.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id 585BC4C48C; Sat, 20 Oct 2018 22:13:31 +0000 (UTC) From: Sergio Durigan Junior To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFC] Make "all" depend on "info" References: <20181020183429.21188-1-tom@tromey.com> Date: Sat, 20 Oct 2018 22:13:00 -0000 In-Reply-To: <20181020183429.21188-1-tom@tromey.com> (Tom Tromey's message of "Sat, 20 Oct 2018 12:34:29 -0600") Message-ID: <87h8hguv04.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00458.txt.bz2 On Saturday, October 20 2018, Tom Tromey wrote: > I've broken "make info" a couple of times now, because I sometimes > forget to run "make info" after modifying a Texinfo file. > > I don't know why gdb's "make all" doesn't build the info pages. I > suspect this was some Cygnus-local oddity back in the day. > > This patch changes doc/Makefile.in so that the info pages are built by > "make all". As a point of reference, Automake has essentially always > worked this way. According to the Automake manual (I didn't > double-check) this is required by the GNU coding standards. I think it makes sense, especially because "info" the default documentation format for GNU. I was wondering if it would also make sense to build the documentation on the BuildBot. > gdb/doc/ChangeLog > 2018-10-20 Tom Tromey > > * Makefile.in (all): Depend on "info". > --- > gdb/doc/ChangeLog | 4 ++++ > gdb/doc/Makefile.in | 2 +- > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/gdb/doc/Makefile.in b/gdb/doc/Makefile.in > index 0323bc4ecb..4e167d59cf 100644 > --- a/gdb/doc/Makefile.in > +++ b/gdb/doc/Makefile.in > @@ -182,7 +182,7 @@ HAVE_NATIVE_GCORE_TARGET = @HAVE_NATIVE_GCORE_TARGET@ > > ### > > -all: > +all: info > > info: $(INFO_DEPS) > dvi: gdb.dvi stabs.dvi refcard.dvi annotate.dvi > -- > 2.17.1 -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/