Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Philippe Waroquiers <philippe.waroquiers@skynet.be>,
	 gdb-patches@sourceware.org
Subject: Re: [RFA] Fix leaks in macro definitions.
Date: Tue, 15 Jan 2019 17:16:00 -0000	[thread overview]
Message-ID: <87h8e9on9h.fsf@tromey.com> (raw)
In-Reply-To: <63b6768fbedbe46b7a46f0d29f7b178c@polymtl.ca> (Simon Marchi's	message of "Tue, 15 Jan 2019 11:50:23 -0500")

>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:

Simon> Would you consider that a bug in the splay tree implementation?
Simon> Should it use the new key and free the old one with the key
Simon> deallocation function?

Yes, I would think so as well, given that we pass key- and
value-deletion functions to splay_tree_new_with_allocator.

Tom


  reply	other threads:[~2019-01-15 17:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-15  5:56 Philippe Waroquiers
2019-01-15 16:50 ` Simon Marchi
2019-01-15 17:16   ` Tom Tromey [this message]
2019-01-15 17:49     ` Simon Marchi
2019-01-15 18:50       ` Tom Tromey
2019-01-15 22:33         ` Tom Tromey
2019-01-15 19:46     ` Philippe Waroquiers
2019-01-15 22:34       ` Tom Tromey
2019-01-17 22:25         ` Tom Tromey
2019-01-19 17:32           ` Philippe Waroquiers
2019-01-19 20:05             ` Tom Tromey
2019-01-15 19:55   ` Philippe Waroquiers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h8e9on9h.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=philippe.waroquiers@skynet.be \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox