From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 42164 invoked by alias); 15 Jan 2019 17:16:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 41799 invoked by uid 89); 15 Jan 2019 17:15:44 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway22.websitewelcome.com Received: from gateway22.websitewelcome.com (HELO gateway22.websitewelcome.com) (192.185.47.129) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 15 Jan 2019 17:15:41 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway22.websitewelcome.com (Postfix) with ESMTP id A760B4E9F2 for ; Tue, 15 Jan 2019 11:15:39 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id jSJPgvdf9dnCejSJPg0Hs0; Tue, 15 Jan 2019 11:15:39 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=GXOV+HctEfbDKRAB9JWjkBvpEFyKbD8huzZhCxNeiho=; b=Ow6aHDS9U9UhATeuO+8np+1aTj DCW31rje99TiZVOHGAEBCdIwVQsoW8+pFQTs7z/BB/jkFrT7wbh7+m/M6Q1lExI1zBWuvG0khnEIw 7aoOSFYC2ilO/VGCUDYpOd/3M; Received: from 75-166-72-210.hlrn.qwest.net ([75.166.72.210]:35598 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gjSJP-000T03-DA; Tue, 15 Jan 2019 11:15:39 -0600 From: Tom Tromey To: Simon Marchi Cc: Philippe Waroquiers , gdb-patches@sourceware.org Subject: Re: [RFA] Fix leaks in macro definitions. References: <20190115055611.17967-1-philippe.waroquiers@skynet.be> <63b6768fbedbe46b7a46f0d29f7b178c@polymtl.ca> Date: Tue, 15 Jan 2019 17:16:00 -0000 In-Reply-To: <63b6768fbedbe46b7a46f0d29f7b178c@polymtl.ca> (Simon Marchi's message of "Tue, 15 Jan 2019 11:50:23 -0500") Message-ID: <87h8e9on9h.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-01/txt/msg00348.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> Would you consider that a bug in the splay tree implementation? Simon> Should it use the new key and free the old one with the key Simon> deallocation function? Yes, I would think so as well, given that we pass key- and value-deletion functions to splay_tree_new_with_allocator. Tom