Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [PATCH 1/2] Print more information in arm_dump_tdep
@ 2020-02-11 17:04 Christian Biesinger via gdb-patches
  2020-02-12 22:05 ` Tom Tromey
  0 siblings, 1 reply; 3+ messages in thread
From: Christian Biesinger via gdb-patches @ 2020-02-11 17:04 UTC (permalink / raw)
  To: gdb-patches; +Cc: Christian Biesinger

I am keeping the (int) casts because a future patch will change the type
to bool.

gdb/ChangeLog:

2020-02-11  Christian Biesinger  <cbiesinger@google.com>

	* arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
---
 gdb/arm-tdep.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c
index cfe128bad2..aa26e6a48e 100644
--- a/gdb/arm-tdep.c
+++ b/gdb/arm-tdep.c
@@ -9468,6 +9468,20 @@ arm_dump_tdep (struct gdbarch *gdbarch, struct ui_file *file)
   if (tdep == NULL)
     return;
 
+  fprintf_unfiltered (file, _("arm_dump_tdep: fp_model = %i\n"),
+		      (int) tdep->fp_model);
+  fprintf_unfiltered (file, _("arm_dump_tdep: have_fpa_registers = %i\n"),
+		      (int) tdep->have_fpa_registers);
+  fprintf_unfiltered (file, _("arm_dump_tdep: have_wmmx_registers = %i\n"),
+		      (int) tdep->have_wmmx_registers);
+  fprintf_unfiltered (file, _("arm_dump_tdep: vfp_register_count = %i\n"),
+		      (int) tdep->vfp_register_count);
+  fprintf_unfiltered (file, _("arm_dump_tdep: have_vfp_pseudos = %i\n"),
+		      (int) tdep->have_vfp_pseudos);
+  fprintf_unfiltered (file, _("arm_dump_tdep: have_neon_pseudos = %i\n"),
+		      (int) tdep->have_neon_pseudos);
+  fprintf_unfiltered (file, _("arm_dump_tdep: have_neon = %i\n"),
+		      (int) tdep->have_neon);
   fprintf_unfiltered (file, _("arm_dump_tdep: Lowest pc = 0x%lx\n"),
 		      (unsigned long) tdep->lowest_pc);
 }
-- 
2.25.0.225.g125e21ebc7-goog


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] Print more information in arm_dump_tdep
  2020-02-11 17:04 [PATCH 1/2] Print more information in arm_dump_tdep Christian Biesinger via gdb-patches
@ 2020-02-12 22:05 ` Tom Tromey
  2020-02-12 22:30   ` Christian Biesinger via gdb-patches
  0 siblings, 1 reply; 3+ messages in thread
From: Tom Tromey @ 2020-02-12 22:05 UTC (permalink / raw)
  To: Christian Biesinger via gdb-patches; +Cc: Christian Biesinger

>>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:

Christian> I am keeping the (int) casts because a future patch will change the type
Christian> to bool.

Christian> gdb/ChangeLog:

Christian> 2020-02-11  Christian Biesinger  <cbiesinger@google.com>

Christian> 	* arm-tdep.c (arm_dump_tdep): Print more fields of tdep.

Looks reasonable to me.  Thanks.

Tom


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] Print more information in arm_dump_tdep
  2020-02-12 22:05 ` Tom Tromey
@ 2020-02-12 22:30   ` Christian Biesinger via gdb-patches
  0 siblings, 0 replies; 3+ messages in thread
From: Christian Biesinger via gdb-patches @ 2020-02-12 22:30 UTC (permalink / raw)
  To: Tom Tromey; +Cc: Christian Biesinger via gdb-patches

On Wed, Feb 12, 2020 at 4:05 PM Tom Tromey <tom@tromey.com> wrote:
>
> >>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:
>
> Christian> I am keeping the (int) casts because a future patch will change the type
> Christian> to bool.
>
> Christian> gdb/ChangeLog:
>
> Christian> 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
>
> Christian>      * arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
>
> Looks reasonable to me.  Thanks.

Thanks, pushed.

Christian


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-02-12 22:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-11 17:04 [PATCH 1/2] Print more information in arm_dump_tdep Christian Biesinger via gdb-patches
2020-02-12 22:05 ` Tom Tromey
2020-02-12 22:30   ` Christian Biesinger via gdb-patches

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox