From: Tom Tromey <tom@tromey.com>
To: simon.marchi@polymtl.ca
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: link with libatomic when it exists
Date: Sat, 07 Feb 2026 08:00:01 -0700 [thread overview]
Message-ID: <87h5rswqdq.fsf@tromey.com> (raw)
In-Reply-To: <20260206222227.2847503-1-simon.marchi@polymtl.ca> (simon marchi's message of "Fri, 6 Feb 2026 17:22:14 -0500")
>>>>> "Simon" == simon marchi <simon.marchi@polymtl.ca> writes:
Simon> We (the ROCgdb team) considered writing a targeted configure check to
Simon> determine if -latomic was needed for this specific edge case, for the
Simon> toolchain in use. But we ended up thinking it would be simpler to just
Simon> always link with libatomic, when it is present. We think there is no
Simon> real downside to it. If libatomic is not really needed, since most
Simon> toolchains now default to using --as-needed, libatomic won't be
Simon> DT_NEEDED if it's not truly needed. Plus, if things change (either our
Simon> code or the compilers) in the future and more things end up requiring
Simon> libatomic, we'll be covered.
Makes sense.
This looks good to me. Thank you.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2026-02-07 15:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-06 22:22 simon.marchi
2026-02-07 15:00 ` Tom Tromey [this message]
2026-02-08 3:43 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h5rswqdq.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox