Re: [PATCH] gdb: link with libatomic when it exists

[Simon Marchi <simon.marchi@polymtl.ca>]

On 2026-02-07 10:00, Tom Tromey wrote:
>>>>>> "Simon" == simon marchi <simon.marchi@polymtl.ca> writes:
> 
> Simon> We (the ROCgdb team) considered writing a targeted configure check to
> Simon> determine if -latomic was needed for this specific edge case, for the
> Simon> toolchain in use.  But we ended up thinking it would be simpler to just
> Simon> always link with libatomic, when it is present.  We think there is no
> Simon> real downside to it.  If libatomic is not really needed, since most
> Simon> toolchains now default to using --as-needed, libatomic won't be
> Simon> DT_NEEDED if it's not truly needed.  Plus, if things change (either our
> Simon> code or the compilers) in the future and more things end up requiring
> Simon> libatomic, we'll be covered.
> 
> Makes sense.
> 
> This looks good to me.  Thank you.
> Approved-By: Tom Tromey <tom@tromey.com>
> 
> Tom

Thanks, pushed.

Simon