Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Tom Tromey <tom@tromey.com>
Cc: Tom de Vries <tdevries@suse.de>,  gdb-patches@sourceware.org
Subject: Re: [PATCH v2] [gdb] Add c_ctrl/c_unctrl
Date: Wed, 25 Mar 2026 14:50:16 -0600	[thread overview]
Message-ID: <87h5q3prav.fsf@tromey.com> (raw)
In-Reply-To: <871ph766cu.fsf@tromey.com> (Tom Tromey's message of "Wed, 25 Mar 2026 13:45:21 -0600")

Tom> I could make this pass somehow, but I don't know how because I don't
Tom> understand what we're actually trying to test here.

Tom> That is, we're already testing all input values.  What else is there
Tom> to test?

> The point is that the function should be a black box and that sign
> extension of chars (on some platforms at least) is the case that
> required this.

> But let's just go ahead.  I don't really care that much.

Sorry about this.  This didn't really come out right.

What I mean is that the benefit of black-box testing is probably
minimal.  So I think there's not much point to doing what I suggested.

Tom

  reply	other threads:[~2026-03-25 20:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-25 12:39 Tom de Vries
2026-03-25 17:40 ` Tom Tromey
2026-03-25 18:12   ` Tom de Vries
2026-03-25 19:45     ` Tom Tromey
2026-03-25 20:50       ` Tom Tromey [this message]
2026-03-26  9:57         ` Tom de Vries
2026-03-26 14:07           ` Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h5q3prav.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox