Re: [PATCH v2] [gdb] Add c_ctrl/c_unctrl

Tom de Vries
2026-03-26T09:58:16Z

On 3/25/26 9:50 PM, Tom Tromey wrote:
> Tom> I could make this pass somehow, but I don't know how because I don't
> Tom> understand what we're actually trying to test here.
>
> Tom> That is, we're already testing all input values. What else is there
> Tom> to test?
>
>> The point is that the function should be a black box and that sign
>> extension of chars (on some platforms at least) is the case that
>> required this.
>
>> But let's just go ahead. I don't really care that much.
>
> Sorry about this. This didn't really come out right.
>

Hi Tom,

no worries, I understood it as a technical comment.

> What I mean is that the benefit of black-box testing is probably
> minimal. So I think there's not much point to doing what I suggested.

I've pushed the patch, but I may submit a follow-up patch implementing
(my current understanding of) your suggestion.

Thanks for the review.

- Tom