From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Fix gdb.fortran/common-block.exp crash in PIE mode
Date: Wed, 06 Feb 2013 16:08:00 -0000 [thread overview]
Message-ID: <87fw19xw61.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20130205211435.GA27223@host2.jankratochvil.net> (Jan Kratochvil's message of "Tue, 5 Feb 2013 22:14:35 +0100")
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
>> Perhaps the various symbol-value accessors like SYMBOL_VALUE_ADDRESS
>> should make assertions about the address class. This is what GCC does
>> in its tree accessors.
>>
>> Like
>>
>> #define SYMBOL_VALUE_COMMON_BLOCK(symbol) \
>> ((gdb_assert (SYMBOL_CLASS (symbol) == LOC_COMMON_BLOCK)), \
>> (symbol)->info.value.common_block)
Jan> Unfortunately these macros are used also for minimal_symbol which
Jan> does not have SYMBOL_CLASS.
Another reason to stop sharing these macros across different types of
symbols. Someday I suppose I'll write up a full patch for that instead
of doing it piecemeal as needed.
Tom
prev parent reply other threads:[~2013-02-06 16:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-19 22:46 Jan Kratochvil
2013-01-21 16:13 ` Tom Tromey
2013-01-21 16:46 ` [commit] " Jan Kratochvil
2013-02-05 21:14 ` Jan Kratochvil
2013-02-06 16:08 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fw19xw61.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox