From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32117 invoked by alias); 6 Feb 2013 16:08:14 -0000 Received: (qmail 32088 invoked by uid 22791); 6 Feb 2013 16:08:12 -0000 X-SWARE-Spam-Status: No, hits=-5.6 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 06 Feb 2013 16:08:08 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r16G88oZ027597 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 6 Feb 2013 11:08:08 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r16G86U4025671 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 6 Feb 2013 11:08:07 -0500 From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch] Fix gdb.fortran/common-block.exp crash in PIE mode References: <20130119224534.GA26330@host2.jankratochvil.net> <874nia4iri.fsf@fleche.redhat.com> <20130205211435.GA27223@host2.jankratochvil.net> Date: Wed, 06 Feb 2013 16:08:00 -0000 In-Reply-To: <20130205211435.GA27223@host2.jankratochvil.net> (Jan Kratochvil's message of "Tue, 5 Feb 2013 22:14:35 +0100") Message-ID: <87fw19xw61.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00148.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: >> Perhaps the various symbol-value accessors like SYMBOL_VALUE_ADDRESS >> should make assertions about the address class. This is what GCC does >> in its tree accessors. >> >> Like >> >> #define SYMBOL_VALUE_COMMON_BLOCK(symbol) \ >> ((gdb_assert (SYMBOL_CLASS (symbol) == LOC_COMMON_BLOCK)), \ >> (symbol)->info.value.common_block) Jan> Unfortunately these macros are used also for minimal_symbol which Jan> does not have SYMBOL_CLASS. Another reason to stop sharing these macros across different types of symbols. Someday I suppose I'll write up a full patch for that instead of doing it piecemeal as needed. Tom