From: Tom Tromey <tromey@redhat.com>
To: Hui Zhu <teawater@gmail.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Let dprintf can be saved
Date: Fri, 19 Apr 2013 18:33:00 -0000 [thread overview]
Message-ID: <87fvymwkbi.fsf@fleche.redhat.com> (raw)
In-Reply-To: <CANFwon0p7x4X1qx=kqu-XRJ0XYfv8NDW4WxqST=w16VDUZTSzw@mail.gmail.com> (Hui Zhu's message of "Thu, 18 Apr 2013 13:36:48 +0800")
>>>>> "Hui" == Hui Zhu <teawater@gmail.com> writes:
Hui> +static void
Hui> +dprintf_print_recreate (struct breakpoint *tp, struct ui_file *fp)
This needs a short introductory comment.
See the other print_recreate methods for examples.
I think this patch could use a test case.
It could be added wherever the existing "save" tests live.
Tom
next prev parent reply other threads:[~2013-04-19 16:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-18 17:04 Hui Zhu
2013-04-19 18:33 ` Tom Tromey [this message]
2013-04-19 18:36 ` Keith Seitz
2013-04-22 0:19 ` Hui Zhu
2013-04-22 0:24 ` Hui Zhu
2013-04-22 23:26 ` Tom Tromey
2013-04-23 16:53 ` Hui Zhu
2013-04-24 14:34 ` Joel Brobecker
2013-04-24 14:35 ` Hui Zhu
2013-04-22 23:47 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fvymwkbi.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox