From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20358 invoked by alias); 19 Apr 2013 16:34:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20346 invoked by uid 89); 19 Apr 2013 16:34:44 -0000 X-Spam-SWARE-Status: No, score=-6.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 19 Apr 2013 16:34:44 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3JGYgw6031502 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 19 Apr 2013 12:34:42 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r3JGYffU029364 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 19 Apr 2013 12:34:41 -0400 From: Tom Tromey To: Hui Zhu Cc: gdb-patches ml Subject: Re: [PATCH] Let dprintf can be saved References: Date: Fri, 19 Apr 2013 18:33:00 -0000 In-Reply-To: (Hui Zhu's message of "Thu, 18 Apr 2013 13:36:48 +0800") Message-ID: <87fvymwkbi.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-04/txt/msg00616.txt.bz2 >>>>> "Hui" == Hui Zhu writes: Hui> +static void Hui> +dprintf_print_recreate (struct breakpoint *tp, struct ui_file *fp) This needs a short introductory comment. See the other print_recreate methods for examples. I think this patch could use a test case. It could be added wherever the existing "save" tests live. Tom