From: Tom Tromey <tromey@redhat.com>
To: Keven Boell <keven.boell@intel.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] testsuite: introduce index in varobj child eval.
Date: Tue, 26 Nov 2013 16:16:00 -0000 [thread overview]
Message-ID: <87fvqj5h3e.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1385467825-5236-1-git-send-email-keven.boell@intel.com> (Keven Boell's message of "Tue, 26 Nov 2013 13:10:25 +0100")
>>>>> "Keven" == Keven Boell <keven.boell@intel.com> writes:
Keven> # Verifies that variable object VARNAME has NUMBER children,
Keven> # where each one is named $VARNAME.<index-of-child> and has type TYPE.
Keven> proc mi_list_array_varobj_children { varname number type testname } {
Keven> + mi_list_array_varobj_children_with_index $varname $number 0 $type $testname
Keven> +}
Keven> +proc mi_list_array_varobj_children_with_index { varname number start_index type testname } {
The new proc should be separated from the previous one by a blank line.
It should have an introductory comment as well.
Also the first line of the new proc is too long. I think it should be
split in the arglist somewhere.
Tom
next prev parent reply other threads:[~2013-11-26 15:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-26 13:35 Keven Boell
2013-11-26 16:16 ` Tom Tromey [this message]
2013-11-27 13:49 ` Keven Boell
2013-11-27 15:58 ` Tom Tromey
2013-11-28 12:25 ` Keven Boell
2013-12-03 20:24 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fvqj5h3e.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=keven.boell@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox