From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-107651-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 16948 invoked by alias); 26 Nov 2013 15:16:23 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 16933 invoked by uid 89); 26 Nov 2013 15:16:22 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RDNS_NONE,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=no version=3.3.2
X-HELO: mx1.redhat.com
Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 26 Nov 2013 15:16:20 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAQFG77K016508	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Tue, 26 Nov 2013 10:16:08 -0500
Received: from barimba (ovpn-113-124.phx2.redhat.com [10.3.113.124])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rAQFG5v6011025	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Tue, 26 Nov 2013 10:16:06 -0500
From: Tom Tromey <tromey@redhat.com>
To: Keven Boell <keven.boell@intel.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] testsuite: introduce index in varobj child eval.
References: <1385467825-5236-1-git-send-email-keven.boell@intel.com>
Date: Tue, 26 Nov 2013 16:16:00 -0000
In-Reply-To: <1385467825-5236-1-git-send-email-keven.boell@intel.com> (Keven	Boell's message of "Tue, 26 Nov 2013 13:10:25 +0100")
Message-ID: <87fvqj5h3e.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2013-11/txt/msg00818.txt.bz2

>>>>> "Keven" == Keven Boell <keven.boell@intel.com> writes:

Keven>  # Verifies that variable object VARNAME has NUMBER children,
Keven>  # where each one is named $VARNAME.<index-of-child> and has type TYPE.
Keven>  proc mi_list_array_varobj_children { varname number type testname } {
Keven> +     mi_list_array_varobj_children_with_index $varname $number 0 $type $testname
Keven> +}
Keven> +proc mi_list_array_varobj_children_with_index { varname number start_index type testname } {

The new proc should be separated from the previous one by a blank line.
It should have an introductory comment as well.

Also the first line of the new proc is too long.  I think it should be
split in the arglist somewhere.

Tom