From: Tom Tromey <tom@tromey.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA 2/3] Move filename extensions into language_defn
Date: Mon, 06 Jun 2016 21:04:00 -0000 [thread overview]
Message-ID: <87fusqvxk0.fsf@tromey.com> (raw)
In-Reply-To: <86r3cawix0.fsf@gmail.com> (Yao Qi's message of "Mon, 06 Jun 2016 14:23:07 +0100")
>>>>> "Yao" == Yao Qi <qiyaoltc@gmail.com> writes:
Yao> Tom Tromey <tom@tromey.com> writes:
>> This moves filename extensions from a function in symfile.c out to
>> each language_defn. I think this is an improvement because it means
>> less digging around when writing a new language port.
Yao> Patch is good to me. Note that we can improve it further by moving
Yao> language related stuff out of symfile.c to language.c. Then, we can
Yao> remove filename_language_table in symfile.c, and use array languages in
Yao> language.c as a replacement.
I considered this, but users can add their own mappings. So, we would
still need both tables. It wouldn't result in a net code removal.
If you want, though, I can still do this.
Tom
next prev parent reply other threads:[~2016-06-06 21:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-04 14:49 [RFA 0/3] minor language cleanups Tom Tromey
2016-06-04 14:49 ` [RFA 2/3] Move filename extensions into language_defn Tom Tromey
2016-06-06 13:23 ` Yao Qi
2016-06-06 21:04 ` Tom Tromey [this message]
2016-06-07 15:51 ` Yao Qi
2016-06-04 14:49 ` [RFA 3/3] Move logic out of symbol_find_demangled_name Tom Tromey
2016-06-06 14:15 ` Yao Qi
2016-06-07 11:41 ` Tom Tromey
2016-06-07 14:27 ` Pedro Alves
2016-06-07 15:12 ` Tom Tromey
2016-06-13 13:35 ` Pedro Alves
2016-06-17 8:28 ` Tom Tromey
2016-06-17 12:25 ` Pedro Alves
2016-06-17 12:36 ` Tom Tromey
2016-06-17 13:50 ` Pedro Alves
2016-06-24 3:15 ` Tom Tromey
2016-06-07 14:03 ` Pedro Alves
2016-06-08 2:14 ` Tom Tromey
2016-06-08 4:03 ` Tom Tromey
2016-06-13 13:35 ` Pedro Alves
2016-06-17 8:41 ` Tom Tromey
2016-06-17 12:28 ` Pedro Alves
2016-06-04 14:49 ` [RFA 1/3] Use VEC for filename_language_table Tom Tromey
2016-06-06 13:06 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fusqvxk0.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox