From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30444 invoked by alias); 6 Jun 2016 21:04:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30435 invoked by uid 89); 6 Jun 2016 21:04:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gproxy8-pub.mail.unifiedlayer.com Received: from gproxy8-pub.mail.unifiedlayer.com (HELO gproxy8-pub.mail.unifiedlayer.com) (67.222.33.93) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Mon, 06 Jun 2016 21:04:40 +0000 Received: (qmail 2888 invoked by uid 0); 6 Jun 2016 21:04:38 -0000 Received: from unknown (HELO cmgw3) (10.0.90.84) by gproxy8.mail.unifiedlayer.com with SMTP; 6 Jun 2016 21:04:38 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id 3Z4b1t00g2f2jeq01Z4eNV; Mon, 06 Jun 2016 15:04:38 -0600 X-Authority-Analysis: v=2.1 cv=KpLehwmN c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=PnD2wP_eR3oA:10 a=-N9Dh3nx2ZYA:10 a=pD_ry4oyNxEA:10 a=pGLkceISAAAA:8 a=zstS-IiYAAAA:8 a=n0HTfv2z46Gchp91fcIA:9 a=6kGIvZw6iX1k4Y-7sg4_:22 a=4G6NA9xxw8l3yy4pmD5M:22 Received: from [65.128.48.199] (port=45378 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.86_2) (envelope-from ) id 1bA1hL-00038w-3f; Mon, 06 Jun 2016 15:04:35 -0600 From: Tom Tromey To: Yao Qi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 2/3] Move filename extensions into language_defn References: <1465051760-25840-1-git-send-email-tom@tromey.com> <1465051760-25840-3-git-send-email-tom@tromey.com> <86r3cawix0.fsf@gmail.com> Date: Mon, 06 Jun 2016 21:04:00 -0000 In-Reply-To: <86r3cawix0.fsf@gmail.com> (Yao Qi's message of "Mon, 06 Jun 2016 14:23:07 +0100") Message-ID: <87fusqvxk0.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.94 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Identified-User: {36111:box522.bluehost.com:elynrobi:tromey.com} {sentby:smtp auth 65.128.48.199 authed with tom+tromey.com} X-Exim-ID: 1bA1hL-00038w-3f X-Source-Sender: (pokyo) [65.128.48.199]:45378 X-Source-Auth: tom+tromey.com X-Email-Count: 0 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-06/txt/msg00116.txt.bz2 >>>>> "Yao" == Yao Qi writes: Yao> Tom Tromey writes: >> This moves filename extensions from a function in symfile.c out to >> each language_defn. I think this is an improvement because it means >> less digging around when writing a new language port. Yao> Patch is good to me. Note that we can improve it further by moving Yao> language related stuff out of symfile.c to language.c. Then, we can Yao> remove filename_language_table in symfile.c, and use array languages in Yao> language.c as a replacement. I considered this, but users can add their own mappings. So, we would still need both tables. It wouldn't result in a net code removal. If you want, though, I can still do this. Tom