From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Eli Zaretskii <eliz@gnu.org>,
gdb-patches@sourceware.org, simon.marchi@ericsson.com,
palves@redhat.com, brobecker@adacore.com,
christophe.lyon@linaro.org
Subject: Re: [PATCH] Conditionally include "<windows.h>" on common/pathstuff.c (and unbreak build on mingw*)
Date: Fri, 02 Mar 2018 18:20:00 -0000 [thread overview]
Message-ID: <87fu5i5og9.fsf@redhat.com> (raw)
In-Reply-To: <625c70bb51eb88e5448d935d523d5919@polymtl.ca> (Simon Marchi's message of "Fri, 02 Mar 2018 10:06:54 -0500")
On Friday, March 02 2018, Simon Marchi wrote:
> On 2018-03-02 08:32, Eli Zaretskii wrote:
>>> From: Sergio Durigan Junior <sergiodj@redhat.com>
>>> Cc: Simon Marchi <simon.marchi@ericsson.com>, Pedro Alves
>>> <palves@redhat.com>, Joel Brobecker <brobecker@adacore.com>,
>>> Christophe Lyon <christophe.lyon@linaro.org>, Sergio Durigan
>>> Junior <sergiodj@redhat.com>
>>> Date: Thu, 1 Mar 2018 15:20:05 -0500
>>>
>>> +#ifdef USE_WIN32API
>>> +#include <windows.h>
>>> +#endif
>>
>> Isn't USE_WIN32API specific to gdbserver? If so, perhaps it's better
>> to use __MINGW32__ or _WIN32 instead?
>
> I see it defined in both gdb and gdbserver:
>
> https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blob;f=gdb/configure.ac;h=698fc7b83456f8c5a63ae0050dc8ec65069290f7;hb=HEAD#l1908
> https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blob;f=gdb/gdbserver/configure.ac;h=99801681ff47ee8dcd9ad2e5ae282dcd113c83e4;hb=HEAD#l281
It's also present on common/filestuff.c, which is shared. That's
actually where I took the idea from.
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
next prev parent reply other threads:[~2018-03-02 18:20 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-10 1:42 [PATCH 0/2] Make gdbserver work with filename-only binaries Sergio Durigan Junior
2018-02-10 1:42 ` [PATCH 1/2] Create new common/pathstuff.[ch] Sergio Durigan Junior
2018-02-11 22:14 ` Simon Marchi
2018-02-12 19:01 ` Sergio Durigan Junior
2018-02-21 7:56 ` Joel Brobecker
2018-02-22 18:43 ` Sergio Durigan Junior
2018-02-10 1:42 ` [PATCH 2/2] Make gdbserver work with filename-only binaries Sergio Durigan Junior
2018-02-12 4:18 ` Simon Marchi
2018-02-12 19:16 ` Sergio Durigan Junior
2018-02-21 8:05 ` Joel Brobecker
2018-02-12 19:57 ` [PATCH 0/2] " Sergio Durigan Junior
2018-02-12 19:57 ` [PATCH v2 1/2] Create new common/pathstuff.[ch] Sergio Durigan Junior
2018-02-12 19:57 ` [PATCH v2 2/2] Make gdbserver work with filename-only binaries Sergio Durigan Junior
2018-02-13 4:35 ` Simon Marchi
2018-02-22 18:37 ` Sergio Durigan Junior
2018-02-21 12:29 ` Pedro Alves
2018-02-27 0:20 ` Sergio Durigan Junior
2018-02-28 3:32 ` Sergio Durigan Junior
2018-02-28 3:27 ` [PATCH v3 0/2] " Sergio Durigan Junior
2018-02-28 3:27 ` [PATCH v3 2/2] " Sergio Durigan Junior
2018-02-28 3:58 ` Sergio Durigan Junior
2018-02-28 5:33 ` Simon Marchi
2018-02-28 7:09 ` Metzger, Markus T
2018-02-28 16:30 ` Sergio Durigan Junior
2018-02-28 5:46 ` Simon Marchi
2018-02-28 16:29 ` Sergio Durigan Junior
2018-02-28 16:40 ` Sergio Durigan Junior
2018-02-28 3:27 ` [PATCH v3 1/2] Create new common/pathstuff.[ch] Sergio Durigan Junior
2018-02-28 5:02 ` Simon Marchi
2018-02-28 16:46 ` Sergio Durigan Junior
2018-02-28 16:39 ` Sergio Durigan Junior
2018-03-01 2:23 ` [PATCH v3 0/2] Make gdbserver work with filename-only binaries Sergio Durigan Junior
2018-03-01 2:55 ` Joel Brobecker
2018-03-01 13:08 ` Christophe Lyon
2018-03-01 13:18 ` Simon Marchi
2018-03-01 19:50 ` Sergio Durigan Junior
2018-03-01 20:20 ` [PATCH] Conditionally include "<windows.h>" on common/pathstuff.c (and unbreak build on mingw*) Sergio Durigan Junior
2018-03-01 20:47 ` Simon Marchi
2018-03-02 11:46 ` Christophe Lyon
2018-03-02 12:35 ` Sergio Durigan Junior
2018-03-02 11:11 ` Yao Qi
2018-03-02 12:29 ` Sergio Durigan Junior
2018-03-02 12:37 ` Sergio Durigan Junior
2018-03-05 12:07 ` Yao Qi
2018-03-02 13:32 ` Eli Zaretskii
2018-03-02 15:15 ` Simon Marchi
2018-03-02 18:20 ` Sergio Durigan Junior [this message]
2018-03-03 7:36 ` Eli Zaretskii
2018-03-01 17:37 ` [PATCH v3 0/2] Make gdbserver work with filename-only binaries Sergio Durigan Junior
2018-03-02 3:20 ` Joel Brobecker
2018-02-28 16:47 ` [obvious/pushed] Change order of error message printed when gdbserver can't find CWD Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fu5i5og9.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=brobecker@adacore.com \
--cc=christophe.lyon@linaro.org \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=simon.marchi@ericsson.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox