From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 371 invoked by alias); 2 Mar 2018 18:20:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 131051 invoked by uid 89); 2 Mar 2018 18:20:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=Hx-languages-length:1276 X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 02 Mar 2018 18:20:40 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2C1C5404084B; Fri, 2 Mar 2018 18:20:39 +0000 (UTC) Received: from localhost (unused-10-15-17-196.yyz.redhat.com [10.15.17.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0BBE22144B24; Fri, 2 Mar 2018 18:20:39 +0000 (UTC) From: Sergio Durigan Junior To: Simon Marchi Cc: Eli Zaretskii , gdb-patches@sourceware.org, simon.marchi@ericsson.com, palves@redhat.com, brobecker@adacore.com, christophe.lyon@linaro.org Subject: Re: [PATCH] Conditionally include "" on common/pathstuff.c (and unbreak build on mingw*) In-Reply-To: <625c70bb51eb88e5448d935d523d5919@polymtl.ca> (Simon Marchi's message of "Fri, 02 Mar 2018 10:06:54 -0500") References: <20180301202005.11563-1-sergiodj@redhat.com> <83h8pywqku.fsf@gnu.org> <625c70bb51eb88e5448d935d523d5919@polymtl.ca> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) Date: Fri, 02 Mar 2018 18:20:00 -0000 Message-ID: <87fu5i5og9.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2018-03/txt/msg00065.txt.bz2 On Friday, March 02 2018, Simon Marchi wrote: > On 2018-03-02 08:32, Eli Zaretskii wrote: >>> From: Sergio Durigan Junior >>> Cc: Simon Marchi , Pedro Alves >>> , Joel Brobecker , >>> Christophe Lyon , Sergio Durigan >>> Junior >>> Date: Thu, 1 Mar 2018 15:20:05 -0500 >>> >>> +#ifdef USE_WIN32API >>> +#include >>> +#endif >> >> Isn't USE_WIN32API specific to gdbserver? If so, perhaps it's better >> to use __MINGW32__ or _WIN32 instead? > > I see it defined in both gdb and gdbserver: > > https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blob;f=gdb/configure.ac;h=698fc7b83456f8c5a63ae0050dc8ec65069290f7;hb=HEAD#l1908 > https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blob;f=gdb/gdbserver/configure.ac;h=99801681ff47ee8dcd9ad2e5ae282dcd113c83e4;hb=HEAD#l281 It's also present on common/filestuff.c, which is shared. That's actually where I took the idea from. -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/