Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Pedro Alves via Gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@polymtl.ca>,
	 Pedro Alves <palves@redhat.com>,
	 Simon Marchi <simon.marchi@efficios.com>,
	 Jon Turney <jon.turney@dronecode.org.uk>
Subject: Re: [PATCH 6/7] gdb: select "Cygwin" OS ABI for Cygwin binaries
Date: Thu, 02 Apr 2020 07:22:18 -0600	[thread overview]
Message-ID: <87ftdmvx85.fsf@tromey.com> (raw)
In-Reply-To: <0b76517a-f6dd-0aa8-17fb-ce5a9accbf42@redhat.com> (Pedro Alves via Gdb-patches's message of "Wed, 1 Apr 2020 22:36:52 +0100")

While reading Pedro's note I noticed:

>> +  const gdb_byte *const idata_contents
>> +    = gdb_bfd_map_section (idata_section, &idata_size);

There's no way to ever release this data.  Since it's only used once, it
may be better to use bfd_get_full_section_contents, so the memory can be
freed when done.

Tom


  parent reply	other threads:[~2020-04-02 13:24 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-16 17:08 [PATCH 0/7] Add "Windows" OS ABI Simon Marchi
2020-03-16 17:08 ` [PATCH 1/7] gdb: recognize 64 bits Windows executables as Cygwin osabi Simon Marchi
2020-03-16 17:08 ` [PATCH 2/7] gdb: move enum gdb_osabi to osabi.h Simon Marchi
2020-03-16 17:08 ` [PATCH 3/7] gdb: add Windows OS ABI Simon Marchi
2020-03-16 17:08 ` [PATCH 4/7] gdb: rename i386-cygwin-tdep.c to i386-windows-tdep.c Simon Marchi
2020-03-16 17:08 ` [PATCH 5/7] gdb: rename content of i386-windows-tdep.c, cygwin to windows Simon Marchi
2020-03-16 17:08 ` [PATCH 6/7] gdb: select "Cygwin" OS ABI for Cygwin binaries Simon Marchi
2020-03-16 18:16   ` Christian Biesinger
2020-03-16 18:18     ` Simon Marchi
2020-03-16 19:03   ` Jon Turney
2020-03-16 21:00     ` Simon Marchi
2020-04-01 19:05   ` Tom Tromey
2020-04-01 19:25     ` Simon Marchi
2020-04-01 21:36   ` Pedro Alves
2020-04-01 21:53     ` Simon Marchi
2020-04-02 13:56       ` Pedro Alves
2020-04-02 14:01         ` Simon Marchi
2020-04-02 14:03           ` Pedro Alves
2020-04-02 14:08             ` Simon Marchi
2020-04-02 14:17               ` Simon Marchi
2020-04-02 13:22     ` Tom Tromey [this message]
2020-04-02 14:55       ` [PATCH] gdb: use bfd_get_section_contents to read section contents in, is_linked_with_cygwin_dll (was: Re: [PATCH 6/7] gdb: select "Cygwin" OS ABI for Cygwin binaries) Simon Marchi
2020-04-02 14:57         ` [PATCH] gdb: use bfd_get_section_contents to read section contents in, is_linked_with_cygwin_dll Simon Marchi
2020-04-02 19:01         ` Tom Tromey
2020-04-02 19:42           ` Simon Marchi
2020-04-02 19:45             ` Tom Tromey
2020-04-02 19:47               ` Simon Marchi
2020-03-16 17:08 ` [PATCH 7/7] gdb: define builtin long type to be 64 bits on amd64 Cygwin Simon Marchi
2020-03-16 17:46 ` [PATCH 0/7] Add "Windows" OS ABI Eli Zaretskii
2020-03-16 17:48   ` Simon Marchi
2020-03-16 19:04     ` Jon Turney
2020-04-01 21:42 ` Pedro Alves
2020-04-01 21:56   ` Simon Marchi
2020-04-02  3:06     ` [PATCH] gdb: stop using host-dependent signal numbers in, windows-tdep.c (was: Re: [PATCH 0/7] Add "Windows" OS ABI) Simon Marchi
2020-04-02 14:00       ` [PATCH] gdb: stop using host-dependent signal numbers in, windows-tdep.c Pedro Alves
2020-04-02 14:02         ` Simon Marchi
2020-04-02 15:12           ` Eli Zaretskii
2020-04-08 12:45           ` Jon Turney
2020-04-08 18:16             ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ftdmvx85.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jon.turney@dronecode.org.uk \
    --cc=palves@redhat.com \
    --cc=simon.marchi@efficios.com \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox