From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway34.websitewelcome.com (gateway34.websitewelcome.com [192.185.149.105]) by sourceware.org (Postfix) with ESMTPS id 6DDB1388A018 for ; Thu, 2 Apr 2020 13:24:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6DDB1388A018 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 4F96294F5F7 for ; Thu, 2 Apr 2020 08:22:19 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id JznXjvR6N1s2xJznXjbP0K; Thu, 02 Apr 2020 08:22:19 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=DDcgIdZgvS1FC9czJom0eLdUM/s1DBowWHggK8MWFZU=; b=QJ9bTOYZZZnND4BsN97OBhq2iJ OLfCGmxnfVhMAwAFWHL1oACQxVqTlto8V6PM9zuMnil941jo1MGfH4s91/JL9k97SvLiixn0+IHU7 tYgx/iSjl1AxmycvD0A6+rvHR; Received: from 174-16-110-145.hlrn.qwest.net ([174.16.110.145]:34796 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jJznW-002PZ2-U7; Thu, 02 Apr 2020 07:22:18 -0600 From: Tom Tromey To: Pedro Alves via Gdb-patches Cc: Simon Marchi , Pedro Alves , Simon Marchi , Jon Turney Subject: Re: [PATCH 6/7] gdb: select "Cygwin" OS ABI for Cygwin binaries References: <20200316170845.184386-1-simon.marchi@polymtl.ca> <20200316170845.184386-7-simon.marchi@polymtl.ca> <0b76517a-f6dd-0aa8-17fb-ce5a9accbf42@redhat.com> X-Attribution: Tom Date: Thu, 02 Apr 2020 07:22:18 -0600 In-Reply-To: <0b76517a-f6dd-0aa8-17fb-ce5a9accbf42@redhat.com> (Pedro Alves via Gdb-patches's message of "Wed, 1 Apr 2020 22:36:52 +0100") Message-ID: <87ftdmvx85.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.110.145 X-Source-L: No X-Exim-ID: 1jJznW-002PZ2-U7 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-110-145.hlrn.qwest.net (murgatroyd) [174.16.110.145]:34796 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Apr 2020 13:24:45 -0000 While reading Pedro's note I noticed: >> + const gdb_byte *const idata_contents >> + = gdb_bfd_map_section (idata_section, &idata_size); There's no way to ever release this data. Since it's only used once, it may be better to use bfd_get_full_section_contents, so the memory can be freed when done. Tom