Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [PUSHED] gdb/doc: use POD2MAN5 when appropriate
@ 2024-06-06 17:03 Andrew Burgess
  2024-06-06 17:08 ` Andrew Burgess
  0 siblings, 1 reply; 3+ messages in thread
From: Andrew Burgess @ 2024-06-06 17:03 UTC (permalink / raw)
  To: gdb-patches; +Cc: Andrew Burgess

In commit:

  commit 824083f34c222aa7419e2ea58e82d6f230d5f531
  Date:   Fri Apr 12 17:47:20 2024 +0100

      gdb/doc: use silent-rules.mk in the Makefile

I rewrote the rules for building the man pages.  While doing this I
accidentally switched from using MAN2POD5 to MAN2POD1 for generating
the file gdbinit.5.

Restore use of MAN2POD5 where appropriate.
---
 gdb/doc/Makefile.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/doc/Makefile.in b/gdb/doc/Makefile.in
index 6a112b98d0e..d9c13873a60 100644
--- a/gdb/doc/Makefile.in
+++ b/gdb/doc/Makefile.in
@@ -679,7 +679,7 @@ $(MAN1S) : %.1 : $(GDB_DOC_FILES)
 
 $(MAN5S) : %.5 : $(GDB_DOC_FILES)
 	$(ECHO_TEXI2POD) $(TEXI2POD) $(MANCONF) -D$* < $(srcdir)/gdb.texinfo > $*.pod
-	$(ECHO_TEXI2MAN) ($(POD2MAN1) $*.pod | sed -e '/^.if n .na/d' > $@.T$$$$ && \
+	$(ECHO_TEXI2MAN) ($(POD2MAN5) $*.pod | sed -e '/^.if n .na/d' > $@.T$$$$ && \
 		mv -f $@.T$$$$ $@) || (rm -f $@.T$$$$ && exit 1)
 	$(SILENCE) rm -f $*.pod
 

base-commit: 61e608693b53a13c48d509a45b329f7ef9dfaa19
-- 
2.25.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PUSHED] gdb/doc: use POD2MAN5 when appropriate
  2024-06-06 17:03 [PUSHED] gdb/doc: use POD2MAN5 when appropriate Andrew Burgess
@ 2024-06-06 17:08 ` Andrew Burgess
  2024-06-06 17:40   ` Joel Brobecker
  0 siblings, 1 reply; 3+ messages in thread
From: Andrew Burgess @ 2024-06-06 17:08 UTC (permalink / raw)
  To: Joel Brobecker, gdb-patches

Andrew Burgess <aburgess@redhat.com> writes:

> In commit:
>
>   commit 824083f34c222aa7419e2ea58e82d6f230d5f531
>   Date:   Fri Apr 12 17:47:20 2024 +0100
>
>       gdb/doc: use silent-rules.mk in the Makefile
>
> I rewrote the rules for building the man pages.  While doing this I
> accidentally switched from using MAN2POD5 to MAN2POD1 for generating
> the file gdbinit.5.
>
> Restore use of MAN2POD5 where appropriate.

Joel,

I've back-ported this fix to the gdb-15-branch too.  Without this the
gdbinit man page will be in the wrong section, e.g.

  man 5 gdbinit

will not return any results.

Thanks,
Andrew




> ---
>  gdb/doc/Makefile.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb/doc/Makefile.in b/gdb/doc/Makefile.in
> index 6a112b98d0e..d9c13873a60 100644
> --- a/gdb/doc/Makefile.in
> +++ b/gdb/doc/Makefile.in
> @@ -679,7 +679,7 @@ $(MAN1S) : %.1 : $(GDB_DOC_FILES)
>  
>  $(MAN5S) : %.5 : $(GDB_DOC_FILES)
>  	$(ECHO_TEXI2POD) $(TEXI2POD) $(MANCONF) -D$* < $(srcdir)/gdb.texinfo > $*.pod
> -	$(ECHO_TEXI2MAN) ($(POD2MAN1) $*.pod | sed -e '/^.if n .na/d' > $@.T$$$$ && \
> +	$(ECHO_TEXI2MAN) ($(POD2MAN5) $*.pod | sed -e '/^.if n .na/d' > $@.T$$$$ && \
>  		mv -f $@.T$$$$ $@) || (rm -f $@.T$$$$ && exit 1)
>  	$(SILENCE) rm -f $*.pod
>  
>
> base-commit: 61e608693b53a13c48d509a45b329f7ef9dfaa19
> -- 
> 2.25.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PUSHED] gdb/doc: use POD2MAN5 when appropriate
  2024-06-06 17:08 ` Andrew Burgess
@ 2024-06-06 17:40   ` Joel Brobecker
  0 siblings, 0 replies; 3+ messages in thread
From: Joel Brobecker @ 2024-06-06 17:40 UTC (permalink / raw)
  To: Andrew Burgess; +Cc: Joel Brobecker, gdb-patches

> I've back-ported this fix to the gdb-15-branch too.  Without this the
> gdbinit man page will be in the wrong section, e.g.
> 
>   man 5 gdbinit
> 
> will not return any results.

Nice one. Thanks for the fix and for the heads up, Andrew.

-- 
Joel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-06-06 17:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-06 17:03 [PUSHED] gdb/doc: use POD2MAN5 when appropriate Andrew Burgess
2024-06-06 17:08 ` Andrew Burgess
2024-06-06 17:40   ` Joel Brobecker

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox