Re: [PATCH] [gdb] Notice when stepping into different file

["Kévin Le Gouguec" <legouguec@adacore.com>]

Tom de Vries <tdevries@suse.de> writes:

> Consider the following test-case:
> ...
> $ cat test.c
> int var;
>
> int
> foo (void)
> {
>   var = 1;
> }

That puzzled me for a few seconds, until I looked at the patch:

> diff --git a/gdb/testsuite/gdb.base/step-into-other-file.c b/gdb/testsuite/gdb.base/step-into-other-file.c
> new file mode 100644
> index 00000000000..5ec7c332739
> --- /dev/null
> +++ b/gdb/testsuite/gdb.base/step-into-other-file.c

> +int var;
> +
> +int
> +foo (void)
> +{
> +  var = 1;
> +#include "step-into-other-file.h"
> +}

Is this Git's core.commentChar acting up?  FWIW, I've found ';' to be a
less fraught comment starter, but YMMV (indenting code samples also
works around the issue, if memory serves).

Changes themselves look good to me in principle, tho not the most
knowledgeable in that area.

Reviewed-By: Kévin Le Gouguec <legouguec@adacore.com>