From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id CHB3FbSIrGY1kTkAWB0awg (envelope-from ) for ; Fri, 02 Aug 2024 03:20:20 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=KdDW5LLX; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 521A51E0D0; Fri, 2 Aug 2024 03:20:20 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2C6CF1E097 for ; Fri, 2 Aug 2024 03:20:18 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DDE35385EC59 for ; Fri, 2 Aug 2024 07:20:17 +0000 (GMT) Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by sourceware.org (Postfix) with ESMTPS id 09227385EC54 for ; Fri, 2 Aug 2024 07:15:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 09227385EC54 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 09227385EC54 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::12f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1722582930; cv=none; b=YcsqniNq0bk+KRiOAmnhO48dNpJz1oHJz41H6XB4BqTslxLysaeKKXun01eGRZ0rLrMG+oDr8Ug/rOxpilMP/hLhDSZBJygRVLCs6qLHrnBL7LVQfo8KTpIBT9v2buEDUndzr9vouGjBpgzAQrGp/Ljcjy7G8cj/qkTOmydvlVw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1722582930; c=relaxed/simple; bh=JvBbt61JUUwBm0sq9vBnk3RQuIJYx0PXyE6hP3PnPhg=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=oDt/kqsRkioP7aTYYqHoLvWRmFU1tsHGxh0SWtoBFO5RJ7f87elrBez3sastOC4hzsx2jYXa3kjHYEXQLUINqdu18wHoREW8sAnSk9JoL7g1OFONLxPPhZeAN9aFy0Fy/SFOD9ePP5+giOGe+63WwnxINAONwXO/rxfh0gcUhIc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-52f04b4abdcso11941512e87.2 for ; Fri, 02 Aug 2024 00:15:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1722582925; x=1723187725; darn=sourceware.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+QbAqkJFy9BH6YRmV8xQTR+wGWSP3c3sV6sG6pa3NU0=; b=KdDW5LLXtgQWhf9GjxEO7NW+pah+hEQSpz9An/gR9KLAkAfo6lQ/OtU16uNet3mA+f 7ru0kCm7ZmHDrwb7Vdef+u75CstbjYCd0E61qgppeOY7YwVBOy2iHS8DC6yAqLZggcU3 biDd8ic4G3jNcXyfz2dRW/eW8yOyuXWvnZTbvFr/OhUhY4Ch8JdkNZSjHU4GynhMwpv/ dJJ7cl/EQG+dcG0V4nYjVnbptkymEm3SlA+s3r3fx8xFnfxJ/zAY5Loo83l3hJAJ61iE nkkNdptW1+xNgq3oayl6es/+ST5La0CzfZ8GPAH68vK8kj6LqhKvtXYEcM/R/GrDp4sJ llAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722582925; x=1723187725; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+QbAqkJFy9BH6YRmV8xQTR+wGWSP3c3sV6sG6pa3NU0=; b=ZQK8tdwkNNBFRqqYJ5NpiDpxpdhKFpz8Q3MPXUwSNPXI7B16rdqU0nzeIRRyNXoI8E 0vpl2YXUY0tw+NTLJRw/gFYxW1asYyzxqZAGOV5CXVMhzxYvPQojINXvzxTtqbWvbyoC jK2w9iZ6KD6JponF12bc2F5SaarmILuvH8p9hfsfpZ6lf7gPs3+5I8iz69L3uvzHXRrt YFaF0cTo+Pa/bQohfyr/acyI8m7WzX3fgPgb7T9sTFcly/Gw9glkphrY4m2Cf/9MnT2e HGnwKKmf4GErXgnpIVkIMkdROUOMvqSGAF2GtQoOH2D9JvVaJC9ErH1e3qXtPHjd9NAW EuvQ== X-Gm-Message-State: AOJu0YzR7oBvYhtaBjTLVSVk6/FDGGNvkBrQIJG2vQq1/2xPxD85SONW /K358nD+Gw04cspYhBI8TjEJrbuTQFbI3JE88cQXRzf9UYQ6ONra8IqWN9hRwZvQU4SWYZXUfj8 = X-Google-Smtp-Source: AGHT+IGNOjq5irT3FHMLO9RGnQExYSJFJ1GEAPDJ+BXTmq9i69IfD1WBlSAewLLnPGXUxe5eO8a8Pw== X-Received: by 2002:a05:6512:6ce:b0:530:aa82:a50a with SMTP id 2adb3069b0e04-530bb395e7fmr1383330e87.45.1722582924893; Fri, 02 Aug 2024 00:15:24 -0700 (PDT) Received: from legouguec-Precision-7550 ([2a01:e0a:253:fe0:6f7b:7bff:6145:63e3]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4282babaa39sm81580805e9.27.2024.08.02.00.15.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Aug 2024 00:15:24 -0700 (PDT) From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] [gdb] Notice when stepping into different file In-Reply-To: <20240802055730.11865-1-tdevries@suse.de> (Tom de Vries's message of "Fri, 2 Aug 2024 07:57:30 +0200") References: <20240802055730.11865-1-tdevries@suse.de> Date: Fri, 02 Aug 2024 09:15:23 +0200 Message-ID: <87frrne6pg.fsf@adacore.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Tom de Vries writes: > Consider the following test-case: > ... > $ cat test.c > int var; > > int > foo (void) > { > var =3D 1; > } That puzzled me for a few seconds, until I looked at the patch: > diff --git a/gdb/testsuite/gdb.base/step-into-other-file.c b/gdb/testsuit= e/gdb.base/step-into-other-file.c > new file mode 100644 > index 00000000000..5ec7c332739 > --- /dev/null > +++ b/gdb/testsuite/gdb.base/step-into-other-file.c > +int var; > + > +int > +foo (void) > +{ > + var =3D 1; > +#include "step-into-other-file.h" > +} Is this Git's core.commentChar acting up? FWIW, I've found ';' to be a less fraught comment starter, but YMMV (indenting code samples also works around the issue, if memory serves). Changes themselves look good to me in principle, tho not the most knowledgeable in that area. Reviewed-By: K=C3=A9vin Le Gouguec