Re: [PATCH v2 2/5] [gdb] Make addrmap_mutable::insert_empty return bool

[Tom Tromey <tom@tromey.com>]

>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

Tom> +      if (addrmap_node_value (n))
Tom> +    {
Tom> +      /* Already mapped.  */
Tom> +      full_range = false;
Tom> +      continue;
Tom> +    }
Tom> +
Tom> +      addrmap_node_set_value (n, obj);

>> FWIW, I still think that they way I wrote is is much better.  My
>> opinion is based on this coding standard rule (
>> https://llvm.org/docs/CodingStandards.html#use-early-exits-and-continue-to-simplify-code
>> ).

I don't think we should use LLVM's coding standards.  Particularly so
now that I've worked on LLVM this last year.

Simon> I also like early returns and early continue in loops.  It tells me: you
Simon> don't need to think about that case for the rest of the function loop.

In this particular case the two branches are single lines.
Using a continue here seems more confusing for that reason -- it's just
more to process here.

I get it for longer loops, at least situationally.

Tom