Re: [PATCH 0/2] More uses of make_unique_xstrdup

[Andrew Burgess <aburgess@redhat.com>]

Tom Tromey <tromey@adacore.com> writes:

> This replaces some uses of '.reset(xstrdup())' with
> '= make_unique_xstrdup()'.  I think explicit uses of reset
> should be avoided when possible.
>
> Regression tested on x86-64 Fedora 41.

All LGTM.

Approved-By: Andrew Burgess <aburgess@redhat.com>

Thanks,
Andrew


>
> Signed-off-by: Tom Tromey <tromey@adacore.com>
> ---
> Tom Tromey (2):
>       Use make_unique_xstrdup in more places
>       Use make_unique_xstrdup in tracepoint
>
>  gdb/breakpoint.c            |  4 ++--
>  gdb/buildsym.h              |  8 +++++---
>  gdb/cli/cli-dump.c          |  2 +-
>  gdb/mi/mi-cmd-env.c         |  2 +-
>  gdb/python/py-framefilter.c |  2 +-
>  gdb/python/py-function.c    |  2 +-
>  gdb/python/py-lazy-string.c |  5 ++++-
>  gdb/python/py-param.c       |  2 +-
>  gdb/solib.c                 |  4 ++--
>  gdb/source.c                |  4 ++--
>  gdb/stack.c                 | 16 +++++++++++-----
>  gdb/tracectf.c              |  4 ++--
>  gdb/tracepoint.c            | 10 ++++------
>  gdb/tracepoint.h            | 12 ++++++------
>  14 files changed, 43 insertions(+), 34 deletions(-)
> ---
> base-commit: 44c39324673cd9bb18db67234253f288497d66a1
> change-id: 20260115-xstrdup-00eb39b61e16
>
> Best regards,
> -- 
> Tom Tromey <tromey@adacore.com>