From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KavVM95HamncVgYAWB0awg (envelope-from ) for ; Fri, 16 Jan 2026 09:14:54 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=F5SSZV/q; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D04571E070; Fri, 16 Jan 2026 09:14:54 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 769AF1E070 for ; Fri, 16 Jan 2026 09:14:54 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 13FC54BA2E35 for ; Fri, 16 Jan 2026 14:14:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 13FC54BA2E35 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=F5SSZV/q Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 661AA4BA2E06 for ; Fri, 16 Jan 2026 14:14:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 661AA4BA2E06 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 661AA4BA2E06 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1768572869; cv=none; b=nGCnB+i+8PiH/FUuSoI9DZOTVjpEQ8iSQw/u5uKkD5VSoas6buzNfvjWOHx0lEuunJuMvh9evjepLidzqAMbIDfxvI+FJApGT0UM1yzU7W1+qnqyYzbSj2YEcFiLaT68XHjc7LoEs/wjbZBwu/xNFupTD4MYJ6Wq59RU8scXdH0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1768572869; c=relaxed/simple; bh=OB68XCs7r61bGAgZyDgLISSBAeGtxvj+gwaI7Q1Y0CM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=xRb/NWK2C63LjQHs3fgtUDqlUbAqQynykrnVWiU+iMvcH5I9e8Zmb8mgZMkIjDi1xu4aAIvb8Xjeqw6O5RvHXwOtEOvVOd4PyRnk/OZeP2N7XFUEp7ioTVK+cBBopCBLLnhOn5KZuXqD4oeC3a6OjNniLQv8cPsDlfh4rlUmx84= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 661AA4BA2E06 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768572869; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZS9QyXtAfHeaG64ssk30YCS4KhMZg3BfOeV0giC9j5I=; b=F5SSZV/qDr30Igvtzb788lGmHLpyJFMimJxJOPXXrWblqXETHzbpS6waomdQV0qgPr5HEQ ZBiweY7XCJSb7IIppantlvXZgl+8U1osGCahCDUy+T7wDuH+ql8oeerjOIi2HnCF7ntPBh OrHwelv8QtyBwAykuCstcalxV6Ueln4= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-632-PhvT65OUMwCI2JsWaHQGoA-1; Fri, 16 Jan 2026 09:14:28 -0500 X-MC-Unique: PhvT65OUMwCI2JsWaHQGoA-1 X-Mimecast-MFC-AGG-ID: PhvT65OUMwCI2JsWaHQGoA_1768572867 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-4310062d97bso1340107f8f.0 for ; Fri, 16 Jan 2026 06:14:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768572866; x=1769177666; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZS9QyXtAfHeaG64ssk30YCS4KhMZg3BfOeV0giC9j5I=; b=DAWtM2bvMTtfe+5Y5t35ZwSkrYnWXLaXMhrR4mbeiDjZFSmCFTVUHwlERl8AibwfSd qZyWX/AxkFmdu9GAxDMnZpeZm/KoSqkhMSPNpNGpAA4Gf5Q03sAAaES/XydAPIa9N8w2 N3+w4jYHYUQ8/SALW2MqMjEWkU1/gcDu7nx5aXg30oi3nHe7oAgR1LsiQ5Pb9Ir+y+F5 TdA5dRjpa2nWmcIp2PXEqhfZxFc06BYeZdABPI/8xPrlEEZmREIkyV116E/Nms3RH4wE ZPvEtCqgNuo+s3DAUgoJ4RmUVVOdAkmcTigSsCLfK4DzTeH8W2mxB71Bg/GSBbQ6NlJY XBoQ== X-Forwarded-Encrypted: i=1; AJvYcCUFlvzfNeUv3cVjBIF0j4Hd0vQh07PJqON4ONcfbaZNw4H4U3d9T73o+kLg/1U0fKDZQUVLwUXsZiflaw==@sourceware.org X-Gm-Message-State: AOJu0YxuHepgwYpW+megOZMRrUvoLGY6ObtlqfPiTgEEYPGYQf+gqgZy e7MuF6JcArdYg17/cU4zlreFxxT6jcxq4i6HMEhMy/QvXTIbH/XPmn6F8hS4okdvc7hJoFNvWeM FOXurwSiIsZ/QG5JSU937zqg+6iyOlJkttfEGmXo1a5xzMqfGRkRveYcc1UcOIH4qr1Pw5aU= X-Gm-Gg: AY/fxX5I0WZ+EuDf5pzduI2MutUI2gsVe8SfedLnnzZiuE4nKXkz5cfMOCLESUVNHBO 5wzr7JaNtDXnp1maPtyHWj3qRKxSKW/QfByrG1m8tp3CFa6y9ERYYcUNzjruTPrfrUSnWWbPzON ieimozT6wQMXZXAzCF4WNKTpvtn4qJ6PZKmMnO1Pv7gvCYW+2lTORaRnMFejPoXz7ZPN52N8Kby ENPPDMH3/lqOL1WrVaZH4MvaUrVgwDTNYX6nJjYYpguhe+EWmoXrWhJHAWsGTq+AroI6Bk/tBho BBqk/1gpSh2e574+RoyHiAUaP0wW9psC0iWPjTElI0H4khYEW/Mvu27ok+ERlSPnElTk1n0LxR5 XDGsgWxpsMFPyTQ9MbbF//eeR1VPS X-Received: by 2002:a05:6000:2c05:b0:42b:3ee9:4776 with SMTP id ffacd0b85a97d-4356a02649cmr4096443f8f.5.1768572866577; Fri, 16 Jan 2026 06:14:26 -0800 (PST) X-Received: by 2002:a05:6000:2c05:b0:42b:3ee9:4776 with SMTP id ffacd0b85a97d-4356a02649cmr4096403f8f.5.1768572866159; Fri, 16 Jan 2026 06:14:26 -0800 (PST) Received: from localhost (13.81.93.209.dyn.plus.net. [209.93.81.13]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4356992211dsm5544868f8f.7.2026.01.16.06.14.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jan 2026 06:14:25 -0800 (PST) From: Andrew Burgess To: Tom Tromey , gdb-patches@sourceware.org Cc: Tom Tromey Subject: Re: [PATCH 0/2] More uses of make_unique_xstrdup In-Reply-To: <20260115-xstrdup-v1-0-72e13ba99851@adacore.com> References: <20260115-xstrdup-v1-0-72e13ba99851@adacore.com> Date: Fri, 16 Jan 2026 14:14:25 +0000 Message-ID: <87fr85skzi.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: EUHa0gHHNvWWoQh7ojOMDrEXSajjtO4jeyKCcEOdJpU_1768572867 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Tom Tromey writes: > This replaces some uses of '.reset(xstrdup())' with > '= make_unique_xstrdup()'. I think explicit uses of reset > should be avoided when possible. > > Regression tested on x86-64 Fedora 41. All LGTM. Approved-By: Andrew Burgess Thanks, Andrew > > Signed-off-by: Tom Tromey > --- > Tom Tromey (2): > Use make_unique_xstrdup in more places > Use make_unique_xstrdup in tracepoint > > gdb/breakpoint.c | 4 ++-- > gdb/buildsym.h | 8 +++++--- > gdb/cli/cli-dump.c | 2 +- > gdb/mi/mi-cmd-env.c | 2 +- > gdb/python/py-framefilter.c | 2 +- > gdb/python/py-function.c | 2 +- > gdb/python/py-lazy-string.c | 5 ++++- > gdb/python/py-param.c | 2 +- > gdb/solib.c | 4 ++-- > gdb/source.c | 4 ++-- > gdb/stack.c | 16 +++++++++++----- > gdb/tracectf.c | 4 ++-- > gdb/tracepoint.c | 10 ++++------ > gdb/tracepoint.h | 12 ++++++------ > 14 files changed, 43 insertions(+), 34 deletions(-) > --- > base-commit: 44c39324673cd9bb18db67234253f288497d66a1 > change-id: 20260115-xstrdup-00eb39b61e16 > > Best regards, > -- > Tom Tromey