Re: [PATCH 1/2] gdb: int to bool in struct entry_info

[Tom Tromey <tom@tromey.com>]

>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:

Andrew> Convert 'struct entry_info' to use bool for flag fields.  The places
Andrew> where these flags are set are updated too.

Andrew> There should be no user visible changes after this commit.

Andrew> -  /* Set to 1 iff ENTRY_POINT contains a valid value.  */
Andrew> -  unsigned entry_point_p : 1;
Andrew> +  /* Set to true iff ENTRY_POINT contains a valid value.  */
Andrew> +  bool entry_point_p : 1;
 
Andrew> -  /* Set to 1 iff this object was initialized.  */
Andrew> -  unsigned initialized : 1;
Andrew> +  /* Set to true iff this object was initialized.  */
Andrew> +  bool initialized : 1;

I think we should only use bit fields where space is at a premium.
Perhaps when using 'unsigned' here this was done to convey that these
are 1-bit entities?  I am not sure.  But anyway I think removing the ":
1" would be an improvement, and since you're touching this line anyway
updating it would be good.

thanks,
Tom