From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id jxK9JJxP4mnGCh8AWB0awg (envelope-from ) for ; Fri, 17 Apr 2026 11:19:56 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=oxTIWSXT; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 7E6521E093; Fri, 17 Apr 2026 11:19:56 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D43891E093 for ; Fri, 17 Apr 2026 11:19:55 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 5E49D4AA3971 for ; Fri, 17 Apr 2026 15:19:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5E49D4AA3971 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=oxTIWSXT Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id 00D144AA3974 for ; Fri, 17 Apr 2026 15:16:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 00D144AA3974 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 00D144AA3974 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776439007; cv=none; b=Vs+K8H8YGQmnQBxGXRMLaRe5Rbsw6LW6pnkef14O5mAdjxYAgO5GK2wbzXg53nH4odeVPtMdeHNRFeeprb0BNw7cLlIc/VY7bCKen4nb9TFH6tGD0LZj4k2SzdVSxWXClTsKp4V1EEjPAKcJk3cdWflS4cMYgGrNXxRfJIHqIL4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776439007; c=relaxed/simple; bh=Wvw39rg4/IAHWp6sEElnUb7BEfR5Jw8OKejdrJ9EU8U=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=q3GDN5eIVA0RkvWWf89nCqI3yoK+TeZph/0ap0G/WBxOTj6XPjaWIEqxUERu+hTnLDMDOmDThpwjAOl2CpUAXxQ10cFr1OdLUzZeo01alyW9yF1cT3pne/txRsrJrj5thOpncfKvBt1mAd0raT4DkQriGSWXF5QYkKBno+sqzKk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 00D144AA3974 Received: from eig-obgw-6003b.ext.cloudfilter.net ([10.0.30.175]) by cmsmtp with ESMTPS id DkpVwCS0Ljw8YDkw1wZQGh; Fri, 17 Apr 2026 15:16:45 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id Dkw1wfnZwHtqhDkw1wWeut; Fri, 17 Apr 2026 15:16:45 +0000 X-Authority-Analysis: v=2.4 cv=AtXu3P9P c=1 sm=1 tr=0 ts=69e24edd a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=A5OVakUREuEA:10 a=ItBw4LHWJt0A:10 a=20KFwNOVAAAA:8 a=EeUrh7EyAOsaQU3qXvIA:9 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ghBcIDineAjlouekrzlpFaSpNFAfinyQhcv8MPWIOXw=; b=oxTIWSXTMu2b9KB2x6a8xnr8/n fYine8elNnpBLwetQz7wThqYNOD4eeCtfnqp7Qi5iwT8cQZzmo5yjAO/7REvZ/A4JqugQ4R6ukP6X WXtu4JbdA/q/9VdwDBvBWwxaH; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:46634 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wDkw0-00000002xqj-4Bq9; Fri, 17 Apr 2026 09:16:45 -0600 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] gdb: int to bool in struct entry_info In-Reply-To: <7eb31f3cc02d146b7c16a1115dd4f5603d2eeb33.1776284661.git.aburgess@redhat.com> (Andrew Burgess's message of "Wed, 15 Apr 2026 21:25:56 +0100") References: <7eb31f3cc02d146b7c16a1115dd4f5603d2eeb33.1776284661.git.aburgess@redhat.com> X-Attribution: Tom Date: Fri, 17 Apr 2026 09:16:42 -0600 Message-ID: <87fr4tty5h.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1wDkw0-00000002xqj-4Bq9 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:46634 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfHpYiLkyStzebrQyDol3gmFqqSkyrF8V96l03v45r2PAuS6TG7KSBjC+YCHOAQVrU5YpQ+cjPysVzUcgN1ayB1FQjrFZJ4KcmT0uZGuoanNSVT05Hknb g+Hond0Cuxjcgg1VJydtwulAHsCgbLdqQ4vQTRiZs+PnhB9rBqWURgH6TtlriIGLU7BkA71sn0us9hXqZkAITxC3d9e83+yTvGU= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Andrew" == Andrew Burgess writes: Andrew> Convert 'struct entry_info' to use bool for flag fields. The places Andrew> where these flags are set are updated too. Andrew> There should be no user visible changes after this commit. Andrew> - /* Set to 1 iff ENTRY_POINT contains a valid value. */ Andrew> - unsigned entry_point_p : 1; Andrew> + /* Set to true iff ENTRY_POINT contains a valid value. */ Andrew> + bool entry_point_p : 1; Andrew> - /* Set to 1 iff this object was initialized. */ Andrew> - unsigned initialized : 1; Andrew> + /* Set to true iff this object was initialized. */ Andrew> + bool initialized : 1; I think we should only use bit fields where space is at a premium. Perhaps when using 'unsigned' here this was done to convey that these are 1-bit entities? I am not sure. But anyway I think removing the ": 1" would be an improvement, and since you're touching this line anyway updating it would be good. thanks, Tom