Re: [PATCH] [gdb/tui] Fix segfault in tui_win_info::forward_scroll

[Tom Tromey <tom@tromey.com>]

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> Dereferencing begin () for an empty range means dereferencing end (), which is
Tom> undefined behavior.  But it happens to set *win_to_scroll to nullptr.

Thanks.

Tom> This behavior is not specified in the documentation or help message, not
Tom> checked in the testsuite and not replicated in any of the other scroll
Tom> methods.

Tom> So an alternative way of fixing this would be to drop the special treatment of
Tom> the command window in parse_scrolling_args, and fix both PRs that way.

I think the choice you made makes sense.

Even if scrolling the command window was possible (there's various bugs
open about this, but it's non-trivial to fix), I think having "+" scroll
it still wouldn't really make sense.

Approved-By: Tom Tromey <tom@tromey.com>

Tom