From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Me0/B+Lr2Gre9wUAWB0awg (envelope-from ) for ; Wed, 21 Oct 2026 12:44:18 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=N6Tjmlpf; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 11C3F1E051; Wed, 21 Oct 2026 12:44:18 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6C7C51E04D for ; Wed, 21 Oct 2026 12:44:17 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 08C024BA23E3 for ; Wed, 21 Oct 2026 16:44:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 08C024BA23E3 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=N6Tjmlpf Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id 36AC84BA7995 for ; Wed, 21 Oct 2026 16:43:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 36AC84BA7995 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 36AC84BA7995 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1792600985; cv=none; b=mTXM53keYKcDmj/qcmKjDZcZmfhRwtGFYtauWpBVspv8vUb1XWLeMzCwR0hXIstZAEpUgTRUMOy1+E5lTMCN1gi/D9iQtdYpVXU/G398icfvpnt32d85lV1WRQNJ5BFsX0xhgAdKIwfa1zXKFDXwkcz7KNoqGhQbBGLgD62Jwkc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1792600985; c=relaxed/simple; bh=kvSmkCty8OeGFvkmIOYLRv1QGLImTxZ1JDT3KwFRxt8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=dXY2o7+Vdthcq09HXZXNIzmhaPQhArpYADQqmbRkx8SXEzNhU0uvcZC2pVE8wCeM1zwT1v86hCOErZt1UB2flswc8LeE0ZGBnDxxy/wXKWqPC3oNzUO/m2p24S7C+IULPWB89N+cr5BV1WL0IIM7AIAQZZkqWfm7OHpGgcP/Pos= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=N6Tjmlpf reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 36AC84BA7995 Received: from eig-obgw-6003b.ext.cloudfilter.net ([10.0.30.175]) by cmsmtp with ESMTPS id JIoNxSyLxMylkJZP6xOcOF; Wed, 21 Oct 2026 16:43:04 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id JZP6xSZtwFNcnJZP6xy8at; Wed, 21 Oct 2026 16:43:04 +0000 X-Authority-Analysis: v=2.4 cv=K+UiHzWI c=1 sm=1 tr=0 ts=6ad8eb98 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=660iZSQnnn4A:10 a=ItBw4LHWJt0A:10 a=zstS-IiYAAAA:8 a=foVovPekA88KdY1OEssA:9 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=0bLao91/y9ObRH3DR/k3SK7xMi2MsAXNZ3J6FzlIlF8=; b=N6TjmlpfSEYTqoC7FiYGQLpeRR 699fQYnR07bMK+UIX6UCy7MqIabZljhQ4t0vTuWFiYBO8UqgldzPRoFsPYpHTsiLt1qJB3oeRqyRT 0RkBZU0sFvIfWUup/zdSJPKG1; Received: from 97-122-110-129.hlrn.qwest.net ([97.122.110.129]:57006 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.100.1) (envelope-from ) id 1xJZP5-00000002txm-2vk6; Wed, 21 Oct 2026 10:43:03 -0600 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] [gdb/tui] Fix segfault in tui_win_info::forward_scroll In-Reply-To: <20261021115918.443487-1-tdevries@suse.de> (Tom de Vries's message of "Wed, 21 Oct 2026 13:59:18 +0200") References: <20261021115918.443487-1-tdevries@suse.de> X-Attribution: Tom Date: Wed, 21 Oct 2026 10:43:02 -0600 Message-ID: <87fqxzypgp.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.110.129 X-Source-L: No X-Exim-ID: 1xJZP5-00000002txm-2vk6 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-110-129.hlrn.qwest.net (bapiya) [97.122.110.129]:57006 X-Source-Auth: tom+tromey.com X-Email-Count: 10 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfLANyTwOBSrJpr5tICbtkfYNRvJfSr8xWYc6J76LBtrx3LUn4ogwTd9ok5YMr8L/WdJewxw5tZWmmtHYabpfsHDfxYcAyE0qmrsMaYo4NpJm2KPS6K80 GyLjkZjTKSXmBJltZIzUFRzXJ6440NDMjRwDd0uuNpTXQCFde4bmnLJ+mSR1MlPk11lNGpHL60h/wIonVbMW+XhMfkMffF3nI0g= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Tom" == Tom de Vries writes: Tom> Dereferencing begin () for an empty range means dereferencing end (), which is Tom> undefined behavior. But it happens to set *win_to_scroll to nullptr. Thanks. Tom> This behavior is not specified in the documentation or help message, not Tom> checked in the testsuite and not replicated in any of the other scroll Tom> methods. Tom> So an alternative way of fixing this would be to drop the special treatment of Tom> the command window in parse_scrolling_args, and fix both PRs that way. I think the choice you made makes sense. Even if scrolling the command window was possible (there's various bugs open about this, but it's non-trivial to fix), I think having "+" scroll it still wouldn't really make sense. Approved-By: Tom Tromey Tom