Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [patch] constify symfile.h section_offsets, section_addr_info
Date: Mon, 06 May 2013 19:37:00 -0000	[thread overview]
Message-ID: <87ehdjyk4x.fsf@fleche.redhat.com> (raw)
In-Reply-To: <CADPb22SA2EbnC73gttgUS4jP7R2-9BkkZR4AESFNXQDC0hVQKg@mail.gmail.com>	(Doug Evans's message of "Mon, 6 May 2013 12:17:10 -0700")

>>>>> "Doug" == Doug Evans <dje@google.com> writes:

Doug> With that, committed.
Doug> Thanks!

I needed this as well.
I'm checking it in.

Tom

2013-05-06  Tom Tromey  <tromey@redhat.com>

	* somread.c (som_symfile_offsets): Add 'const' to addrs.
	* machoread.c (macho_symfile_offsets): Add 'const' to addrs.
	* xcoffread.c (xcoff_symfile_offsets): Add 'const' to addrs.
	Remove declaration.

Index: machoread.c
===================================================================
RCS file: /cvs/src/src/gdb/machoread.c,v
retrieving revision 1.50
diff -u -r1.50 machoread.c
--- machoread.c	8 Apr 2013 20:13:21 -0000	1.50
+++ machoread.c	6 May 2013 19:36:41 -0000
@@ -968,7 +968,7 @@
 
 static void
 macho_symfile_offsets (struct objfile *objfile,
-                       struct section_addr_info *addrs)
+                       const struct section_addr_info *addrs)
 {
   unsigned int i;
   unsigned int num_sections;
Index: somread.c
===================================================================
RCS file: /cvs/src/src/gdb/somread.c,v
retrieving revision 1.61
diff -u -r1.61 somread.c
--- somread.c	8 Apr 2013 20:13:22 -0000	1.61
+++ somread.c	6 May 2013 19:36:41 -0000
@@ -487,7 +487,8 @@
    Plain and simple for now.  */
 
 static void
-som_symfile_offsets (struct objfile *objfile, struct section_addr_info *addrs)
+som_symfile_offsets (struct objfile *objfile,
+		     const struct section_addr_info *addrs)
 {
   int i;
   CORE_ADDR text_addr;
Index: xcoffread.c
===================================================================
RCS file: /cvs/src/src/gdb/xcoffread.c,v
retrieving revision 1.113
diff -u -r1.113 xcoffread.c
--- xcoffread.c	6 May 2013 14:15:50 -0000	1.113
+++ xcoffread.c	6 May 2013 19:36:41 -0000
@@ -220,9 +220,6 @@
 
 static void xcoff_symfile_finish (struct objfile *);
 
-static void xcoff_symfile_offsets (struct objfile *,
-				   struct section_addr_info *addrs);
-
 static char *coff_getfilename (union internal_auxent *, struct objfile *);
 
 static void read_symbol (struct internal_syment *, int);
@@ -3038,7 +3035,7 @@
 \f
 static void
 xcoff_symfile_offsets (struct objfile *objfile,
-		       struct section_addr_info *addrs)
+		       const struct section_addr_info *addrs)
 {
   const char *first_section_name;
 


  reply	other threads:[~2013-05-06 19:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-06 16:52 Doug Evans
2013-05-06 18:37 ` Tom Tromey
2013-05-06 19:17   ` Doug Evans
2013-05-06 19:37     ` Tom Tromey [this message]
2013-05-06 19:40       ` Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ehdjyk4x.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox