From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12470 invoked by alias); 6 May 2013 19:37:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12459 invoked by uid 89); 6 May 2013 19:37:55 -0000 X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS,TW_BJ,TW_YM autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 06 May 2013 19:37:54 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r46JbqP2025921 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 6 May 2013 15:37:52 -0400 Received: from barimba (ovpn-113-163.phx2.redhat.com [10.3.113.163]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r46Jbo17030504 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 6 May 2013 15:37:51 -0400 From: Tom Tromey To: Doug Evans Cc: gdb-patches Subject: Re: [patch] constify symfile.h section_offsets, section_addr_info References: <87d2t4ymxl.fsf@fleche.redhat.com> Date: Mon, 06 May 2013 19:37:00 -0000 In-Reply-To: (Doug Evans's message of "Mon, 6 May 2013 12:17:10 -0700") Message-ID: <87ehdjyk4x.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-05/txt/msg00142.txt.bz2 >>>>> "Doug" == Doug Evans writes: Doug> With that, committed. Doug> Thanks! I needed this as well. I'm checking it in. Tom 2013-05-06 Tom Tromey * somread.c (som_symfile_offsets): Add 'const' to addrs. * machoread.c (macho_symfile_offsets): Add 'const' to addrs. * xcoffread.c (xcoff_symfile_offsets): Add 'const' to addrs. Remove declaration. Index: machoread.c =================================================================== RCS file: /cvs/src/src/gdb/machoread.c,v retrieving revision 1.50 diff -u -r1.50 machoread.c --- machoread.c 8 Apr 2013 20:13:21 -0000 1.50 +++ machoread.c 6 May 2013 19:36:41 -0000 @@ -968,7 +968,7 @@ static void macho_symfile_offsets (struct objfile *objfile, - struct section_addr_info *addrs) + const struct section_addr_info *addrs) { unsigned int i; unsigned int num_sections; Index: somread.c =================================================================== RCS file: /cvs/src/src/gdb/somread.c,v retrieving revision 1.61 diff -u -r1.61 somread.c --- somread.c 8 Apr 2013 20:13:22 -0000 1.61 +++ somread.c 6 May 2013 19:36:41 -0000 @@ -487,7 +487,8 @@ Plain and simple for now. */ static void -som_symfile_offsets (struct objfile *objfile, struct section_addr_info *addrs) +som_symfile_offsets (struct objfile *objfile, + const struct section_addr_info *addrs) { int i; CORE_ADDR text_addr; Index: xcoffread.c =================================================================== RCS file: /cvs/src/src/gdb/xcoffread.c,v retrieving revision 1.113 diff -u -r1.113 xcoffread.c --- xcoffread.c 6 May 2013 14:15:50 -0000 1.113 +++ xcoffread.c 6 May 2013 19:36:41 -0000 @@ -220,9 +220,6 @@ static void xcoff_symfile_finish (struct objfile *); -static void xcoff_symfile_offsets (struct objfile *, - struct section_addr_info *addrs); - static char *coff_getfilename (union internal_auxent *, struct objfile *); static void read_symbol (struct internal_syment *, int); @@ -3038,7 +3035,7 @@ static void xcoff_symfile_offsets (struct objfile *objfile, - struct section_addr_info *addrs) + const struct section_addr_info *addrs) { const char *first_section_name;