* [PATCH] pass v2 instead of base_type to value_type.
@ 2013-08-29 14:13 Sanimir Agovic
2013-08-29 14:21 ` Tom Tromey
0 siblings, 1 reply; 3+ messages in thread
From: Sanimir Agovic @ 2013-08-29 14:13 UTC (permalink / raw)
To: gdb-patches, tromey
Broke the gdb build with my last commit. Fix below.
* valops.c (do_search_struct_field): Pass v2 instead of base_type to
value_type.
---
gdb/valops.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gdb/valops.c b/gdb/valops.c
index 890735e..15fd7c3 100644
--- a/gdb/valops.c
+++ b/gdb/valops.c
@@ -1954,7 +1954,7 @@ do_search_struct_field (const char *name, struct value *arg1, int offset,
v2 = value_at_lazy (basetype, base_addr);
if (target_read_memory (base_addr,
value_contents_raw (v2),
- TYPE_LENGTH (value_type (basetype))) != 0)
+ TYPE_LENGTH (value_type (v2))) != 0)
error (_("virtual baseclass botch"));
}
else
--
1.7.1.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pass v2 instead of base_type to value_type.
2013-08-29 14:13 [PATCH] pass v2 instead of base_type to value_type Sanimir Agovic
@ 2013-08-29 14:21 ` Tom Tromey
2013-08-29 14:27 ` Agovic, Sanimir
0 siblings, 1 reply; 3+ messages in thread
From: Tom Tromey @ 2013-08-29 14:21 UTC (permalink / raw)
To: Sanimir Agovic; +Cc: gdb-patches
>>>>> "Sanimir" == Sanimir Agovic <sanimir.agovic@intel.com> writes:
Sanimir> * valops.c (do_search_struct_field): Pass v2 instead of base_type to
Sanimir> value_type.
Ok.
Really this could go in under the obvious rule.
Tom
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] pass v2 instead of base_type to value_type.
2013-08-29 14:21 ` Tom Tromey
@ 2013-08-29 14:27 ` Agovic, Sanimir
0 siblings, 0 replies; 3+ messages in thread
From: Agovic, Sanimir @ 2013-08-29 14:27 UTC (permalink / raw)
To: 'Tom Tromey'; +Cc: gdb-patches
> Sanimir> * valops.c (do_search_struct_field): Pass v2 instead of base_type to
> Sanimir> value_type.
>
> Ok.
> Really this could go in under the obvious rule.
>
> Tom
>
Thank, committed.
-Sanimir
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-08-29 14:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-29 14:13 [PATCH] pass v2 instead of base_type to value_type Sanimir Agovic
2013-08-29 14:21 ` Tom Tromey
2013-08-29 14:27 ` Agovic, Sanimir
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox