Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Doug Evans <dje@gmail.com>
Cc: gdb-patches@sourceware.org, binutils@sourceware.org
Subject: Re: [PATCH] include/gdb/section-scripts.h: New file.
Date: Mon, 02 Dec 2013 15:19:00 -0000	[thread overview]
Message-ID: <87eh5vwaa3.fsf@fleche.redhat.com> (raw)
In-Reply-To: <m3fvqf3unp.fsf@sspiff.sspiff.org> (Doug Evans's message of "Fri,	29 Nov 2013 10:55:06 -0800")

>>>>> "Doug" == Doug Evans <dje@gmail.com> writes:

Doug> This patch creates a file to use when adding values to
Doug> .debug_gdb_scripts.

I don't see why this needs to go in include.

I think it would be more helpful to document the format of this section
in the manual.

Doug> +/* Native GDB scripts are not currently supported in .debug_gdb_scripts,
Doug> +   but we reserve a value for it.  */
Doug> +/*#define SECTION_SCRIPT_ID_GDB_FILE 2*/

There's no need either to reserve a value or to add commented out code.

Tom


  reply	other threads:[~2013-12-02 15:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-29 19:59 Doug Evans
2013-12-02 15:19 ` Tom Tromey [this message]
2013-12-02 17:01   ` Doug Evans
2013-12-03 16:17     ` Doug Evans
2013-12-05 21:07     ` Tom Tromey
2013-12-07 20:56       ` Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eh5vwaa3.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=binutils@sourceware.org \
    --cc=dje@gmail.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox