From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-107835-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 23069 invoked by alias); 2 Dec 2013 15:19:29 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 23043 invoked by uid 89); 2 Dec 2013 15:19:27 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.2
X-Spam-User: qpsmtpd, 2 recipients
X-HELO: mx1.redhat.com
Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 02 Dec 2013 15:19:26 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rB2FJHbu029974	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Mon, 2 Dec 2013 10:19:17 -0500
Received: from barimba (ovpn-113-124.phx2.redhat.com [10.3.113.124])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rB2FJGfM031940	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Mon, 2 Dec 2013 10:19:16 -0500
From: Tom Tromey <tromey@redhat.com>
To: Doug Evans <dje@gmail.com>
Cc: gdb-patches@sourceware.org, binutils@sourceware.org
Subject: Re: [PATCH] include/gdb/section-scripts.h: New file.
References: <m3fvqf3unp.fsf@sspiff.sspiff.org>
Date: Mon, 02 Dec 2013 15:19:00 -0000
In-Reply-To: <m3fvqf3unp.fsf@sspiff.sspiff.org> (Doug Evans's message of "Fri,	29 Nov 2013 10:55:06 -0800")
Message-ID: <87eh5vwaa3.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2013-12/txt/msg00039.txt.bz2

>>>>> "Doug" == Doug Evans <dje@gmail.com> writes:

Doug> This patch creates a file to use when adding values to
Doug> .debug_gdb_scripts.

I don't see why this needs to go in include.

I think it would be more helpful to document the format of this section
in the manual.

Doug> +/* Native GDB scripts are not currently supported in .debug_gdb_scripts,
Doug> +   but we reserve a value for it.  */
Doug> +/*#define SECTION_SCRIPT_ID_GDB_FILE 2*/

There's no need either to reserve a value or to add commented out code.

Tom