From: Tom Tromey <tromey@redhat.com>
To: Hui Zhu <hui_zhu@mentor.com>
Cc: Sergio Durigan Junior <sergiodj@redhat.com>,
gdb-patches ml <gdb-patches@sourceware.org>,
Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>,
Nick Clifton <nickc@redhat.com>
Subject: Re: [PATCH] Remove gdb_bfd_stash_filename to fix crash with fix of binutils/11983
Date: Mon, 06 Jan 2014 16:14:00 -0000 [thread overview]
Message-ID: <87eh4lozp3.fsf@fleche.redhat.com> (raw)
In-Reply-To: <52CA8A7F.7090907@mentor.com> (Hui Zhu's message of "Mon, 6 Jan 2014 18:50:39 +0800")
>>>>> "Hui" == Hui Zhu <hui_zhu@mentor.com> writes:
>> solib-spu.c:spu_bfd_open
>> spu-linux-nat.c:spu_bfd_open
Hui> These two functions have used xstrdup, for example:
Oops, yeah. Thanks.
Hui> 2014-01-06 Hui Zhu <hui@codesourcery.com>
Hui> * gdb_bfd.c (gdb_bfd_stash_filename): Removed.
Hui> (gdb_bfd_open): Removed gdb_bfd_stash_filename.
Hui> (gdb_bfd_fopen): Ditto.
Hui> (gdb_bfd_openr): Ditto.
Hui> (gdb_bfd_openw): Ditto.
Hui> (gdb_bfd_openr_iovec): Ditto.
Hui> (gdb_bfd_fdopenr): Ditto.
Hui> * gdb_bfd.h (gdb_bfd_stash_filename): Removed.
Hui> * solib-aix.c (solib_aix_bfd_open): Alloc object_bfd->filename
Hui> with xstrdup.
Hui> * solib-darwin.c (darwin_bfd_open): Alloc res->filename
Hui> with xstrdup.
Hui> * symfile-mem.c (symbol_file_add_from_memory): Removed
Hui> gdb_bfd_stash_filename.
This is ok.
Tom
next prev parent reply other threads:[~2014-01-06 16:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-04 16:23 Hui Zhu
2014-01-05 15:06 ` Sergio Durigan Junior
2014-01-05 15:48 ` Hui Zhu
2014-01-06 8:25 ` Tom Tromey
2014-01-06 10:50 ` Hui Zhu
2014-01-06 16:14 ` Tom Tromey [this message]
2014-01-06 17:12 ` Doug Evans
2014-01-06 21:07 ` Tom Tromey
2014-01-07 12:35 ` Pedro Alves
2014-01-07 13:55 ` Pedro Alves
2014-01-07 17:41 ` Tom Tromey
2014-01-07 19:54 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eh4lozp3.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=emachado@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=hui_zhu@mentor.com \
--cc=nickc@redhat.com \
--cc=sergiodj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox