From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14710 invoked by alias); 6 Jan 2014 16:14:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14698 invoked by uid 89); 6 Jan 2014 16:14:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 06 Jan 2014 16:14:05 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s06GE22V003845 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 6 Jan 2014 11:14:02 -0500 Received: from barimba (ovpn-113-85.phx2.redhat.com [10.3.113.85]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s06GE06w013321 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 6 Jan 2014 11:14:01 -0500 From: Tom Tromey To: Hui Zhu Cc: Sergio Durigan Junior , gdb-patches ml , Edjunior Barbosa Machado , Nick Clifton Subject: Re: [PATCH] Remove gdb_bfd_stash_filename to fix crash with fix of binutils/11983 References: <52C8358B.7080101@mentor.com> <52C97EC0.3080807@mentor.com> <87k3edseia.fsf@fleche.redhat.com> <52CA8A7F.7090907@mentor.com> Date: Mon, 06 Jan 2014 16:14:00 -0000 In-Reply-To: <52CA8A7F.7090907@mentor.com> (Hui Zhu's message of "Mon, 6 Jan 2014 18:50:39 +0800") Message-ID: <87eh4lozp3.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-01/txt/msg00060.txt.bz2 >>>>> "Hui" == Hui Zhu writes: >> solib-spu.c:spu_bfd_open >> spu-linux-nat.c:spu_bfd_open Hui> These two functions have used xstrdup, for example: Oops, yeah. Thanks. Hui> 2014-01-06 Hui Zhu Hui> * gdb_bfd.c (gdb_bfd_stash_filename): Removed. Hui> (gdb_bfd_open): Removed gdb_bfd_stash_filename. Hui> (gdb_bfd_fopen): Ditto. Hui> (gdb_bfd_openr): Ditto. Hui> (gdb_bfd_openw): Ditto. Hui> (gdb_bfd_openr_iovec): Ditto. Hui> (gdb_bfd_fdopenr): Ditto. Hui> * gdb_bfd.h (gdb_bfd_stash_filename): Removed. Hui> * solib-aix.c (solib_aix_bfd_open): Alloc object_bfd->filename Hui> with xstrdup. Hui> * solib-darwin.c (darwin_bfd_open): Alloc res->filename Hui> with xstrdup. Hui> * symfile-mem.c (symbol_file_add_from_memory): Removed Hui> gdb_bfd_stash_filename. This is ok. Tom