Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Make format_pieces recognize the \e escape sequence
Date: Thu, 17 May 2018 17:08:00 -0000	[thread overview]
Message-ID: <87efiaguyd.fsf@tromey.com> (raw)
In-Reply-To: <1526564365-4036-1-git-send-email-simon.marchi@ericsson.com>	(Simon Marchi's message of "Thu, 17 May 2018 09:39:25 -0400")

>>>>> "Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:

Simon> I noticed that the printf command did not recognize the \e escape
Simon> sequence, used amongst other things to use colors:

Simon>   (gdb) printf "This is \e[32mgreen\e[m!\n"
Simon>   Unrecognized escape character \e in format string.

Simon> This patch makes format_pieces recognize it, which makes that command
Simon> print the expected result in glorious color.

Thanks.  The patch looked reasonable to me.

Maybe this could be considered part of PR 14975.

Tom


  reply	other threads:[~2018-05-17 15:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-17 14:36 Simon Marchi
2018-05-17 17:08 ` Tom Tromey [this message]
2018-05-17 17:23   ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87efiaguyd.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@ericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox