From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 119253 invoked by alias); 17 May 2018 15:31:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 118193 invoked by uid 89); 17 May 2018 15:31:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway24.websitewelcome.com Received: from gateway24.websitewelcome.com (HELO gateway24.websitewelcome.com) (192.185.51.253) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 17 May 2018 15:31:25 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 1E1FF17B89 for ; Thu, 17 May 2018 10:31:24 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id JKsGfyDStWCOCJKsGfortW; Thu, 17 May 2018 10:31:24 -0500 X-Authority-Reason: nr=8 Received: from 174-29-44-154.hlrn.qwest.net ([174.29.44.154]:47874 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1fJKsF-002kpe-Qw; Thu, 17 May 2018 10:31:23 -0500 From: Tom Tromey To: Simon Marchi Cc: Subject: Re: [PATCH] Make format_pieces recognize the \e escape sequence References: <1526564365-4036-1-git-send-email-simon.marchi@ericsson.com> Date: Thu, 17 May 2018 17:08:00 -0000 In-Reply-To: <1526564365-4036-1-git-send-email-simon.marchi@ericsson.com> (Simon Marchi's message of "Thu, 17 May 2018 09:39:25 -0400") Message-ID: <87efiaguyd.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1fJKsF-002kpe-Qw X-Source-Sender: 174-29-44-154.hlrn.qwest.net (pokyo) [174.29.44.154]:47874 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-05/txt/msg00383.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> I noticed that the printf command did not recognize the \e escape Simon> sequence, used amongst other things to use colors: Simon> (gdb) printf "This is \e[32mgreen\e[m!\n" Simon> Unrecognized escape character \e in format string. Simon> This patch makes format_pieces recognize it, which makes that command Simon> print the expected result in glorious color. Thanks. The patch looked reasonable to me. Maybe this could be considered part of PR 14975. Tom