Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Weimin Pan <weimin.pan@oracle.com>,  gdb-patches@sourceware.org
Subject: Re: [PATCH] Removing lookup_minimal_symbol_and_objfile
Date: Sun, 27 May 2018 20:56:00 -0000	[thread overview]
Message-ID: <87efhxyum5.fsf@tromey.com> (raw)
In-Reply-To: <a8498e16bb9166ad20c8c80aaad2222b@polymtl.ca> (Simon Marchi's	message of "Fri, 25 May 2018 21:24:53 -0400")

>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:

Simon> AFAIK, they do exactly the same thing, so we can get rid of one
Simon> (and lookup_minimal_symbol_and_objfile happens to be the most
Simon> inefficient because it ends up n^2 on the number of objfiles).

lookup_bound_minimal_symbol could also be removed if you don't mind default
arguments on lookup_minimal_symbol.

Tom


  reply	other threads:[~2018-05-27 15:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-15 14:45 Weimin Pan
2018-05-27  3:57 ` Simon Marchi
2018-05-27 20:56   ` Tom Tromey [this message]
2018-05-29 17:25   ` Wei-min Pan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87efhxyum5.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@polymtl.ca \
    --cc=weimin.pan@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox