From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 89646 invoked by alias); 27 May 2018 15:40:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 89635 invoked by uid 89); 27 May 2018 15:40:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=afaik, H*i:sk:a8498e1, AFAIK, H*Ad:D*oracle.com X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.148.2) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 27 May 2018 15:40:54 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway30.websitewelcome.com (Postfix) with ESMTP id B1A1F103AC for ; Sun, 27 May 2018 10:40:52 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id MxmufrsBmkBj6MxmufNAjt; Sun, 27 May 2018 10:40:52 -0500 X-Authority-Reason: nr=8 Received: from 174-29-44-154.hlrn.qwest.net ([174.29.44.154]:44338 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fMxmt-004DrU-NG; Sun, 27 May 2018 10:40:51 -0500 From: Tom Tromey To: Simon Marchi Cc: Weimin Pan , gdb-patches@sourceware.org Subject: Re: [PATCH] Removing lookup_minimal_symbol_and_objfile References: <1526343059-25143-1-git-send-email-weimin.pan@oracle.com> Date: Sun, 27 May 2018 20:56:00 -0000 In-Reply-To: (Simon Marchi's message of "Fri, 25 May 2018 21:24:53 -0400") Message-ID: <87efhxyum5.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1fMxmt-004DrU-NG X-Source-Sender: 174-29-44-154.hlrn.qwest.net (bapiya) [174.29.44.154]:44338 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-05/txt/msg00719.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> AFAIK, they do exactly the same thing, so we can get rid of one Simon> (and lookup_minimal_symbol_and_objfile happens to be the most Simon> inefficient because it ends up n^2 on the number of objfiles). lookup_bound_minimal_symbol could also be removed if you don't mind default arguments on lookup_minimal_symbol. Tom